config: support online change lock manager config #6338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: linning <linningde25@gmail.com>
overvenus
reviewed
Dec 27, 2019
| // Create CoprocessorHost. | ||
| let mut coprocessor_host = | ||
| CoprocessorHost::new(self.config.coprocessor.clone(), self.router.clone()); | ||
|
|
||
| let lock_mgr = if self.config.pessimistic_txn.enabled { | ||
| let lock_mgr = LockManager::new(); | ||
| cfg_controller.register("pessimistic_txn", Box::new(lock_mgr.config_manager())); |
There was a problem hiding this comment.
pessimistic_txn or pessimistic-txn?
There was a problem hiding this comment.
pessimistic_txn same as the TiKvConfig field name.
| change.remove("wait_for_lock_timeout").map(Into::into), | ||
| change.remove("wake_up_delay_duration").map(Into::into), | ||
| ) { | ||
| (timeout @ Some(_), delay) => { |
There was a problem hiding this comment.
WaiterManager need to listening both update of timeout and delay, even one of them are not change (represent as None here), we still need to dispatch the change to it, and WaiterManager::handle_config_change will take care of various situations.
| @@ -319,6 +329,9 @@ impl Display for Task { | |||
| ), | |||
| Task::DetectRpc { .. } => write!(f, "Detect Rpc"), | |||
| Task::ChangeRole(role) => write!(f, "ChangeRole {{ role: {:?} }}", role), | |||
| Task::ChangeTTL(ttl) => write!(f, "ChangeTTL {{ ttl: {:?} }}", ttl), | |||
There was a problem hiding this comment.
Suggested change
| Task::ChangeTTL(ttl) => write!(f, "ChangeTTL {{ ttl: {:?} }}", ttl), | |
| Task::ChangeTTL(ttl) => write!(f, "ChangeTTL { ttl: {:?} }", ttl), |
There was a problem hiding this comment.
we need {{ here to print out {, so Task::ChangeTTL print something like ChangeTTL { ttl: 100ms }.
Signed-off-by: linning <linningde25@gmail.com>
|
/run-all-tests |
|
@NingLin-P merge failed. |
|
/merge |
|
/run-all-tests |
c1ay
pushed a commit
to c1ay/tikv
that referenced
this pull request
May 9, 2020
Signed-off-by: linning <linningde25@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed?
This pr is part of online change config.
This pr add support for online change lock manager config by adding new tasks to lock manger (
Task::ChangeConfigandTask::ChangeTTL).What is the type of the changes?
How is the PR tested?
Does this PR affect documentation (docs) or should it be mentioned in the release notes?
No
Does this PR affect
tidb-ansible?No