copr: chunk time use new 8 byte format #6418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: TennyZhuang <zty0826@gmail.com>
|
any benchmark for this? |
|
Added a DNM label since it must be merged together with pingcap/tidb#14278 |
|
/run-all-tests |
Signed-off-by: TennyZhuang <zty0826@gmail.com>
|
/run-integration-tests |
1 similar comment
|
/run-integration-tests |
|
@sre-bot /run-integration-tests |
|
/run-integration-tests |
|
/bench +sysbench +tpch tidb=pr/14278 |
|
/run-all-tests tidb=pr/14278 tidb-test=pr/975 |
Benchmark Report
@@ Benchmark Diff @@
================================================================================
--- tidb: 5c874403fdf96dd4406e152b1fd39231a53f79b3
+++ tidb: 9af875d1ad64af79cccb087e0df2ae392475e0ef
--- tikv: a9be441bdabe328cf29714aa0410df18e694f9fb
+++ tikv: dc199420a9bca35f4628d0616d8bff3320ffd098
pd: 49f194a85bde1d9da12e453faea80236049be3c7
================================================================================
oltp_insert:
* QPS: 4699.89 ± 0.14% (std=5.23) delta: 0.08% (p=0.742)
* Latency p50: 27.23 ± 0.14% (std=0.03) delta: 0.05%
* Latency p99: 46.88 ± 6.90% (std=1.96) delta: 2.80%
oltp_point_select:
* QPS: 43464.05 ± 0.31% (std=87.89) delta: -0.12% (p=0.693)
* Latency p50: 2.94 ± 0.42% (std=0.01) delta: 0.09%
* Latency p99: 9.91 ± 0.00% (std=0.00) delta: 0.00%
oltp_read_write:
* QPS: 15603.48 ± 0.88% (std=89.79) delta: -0.20% (p=0.683)
* Latency p50: 164.41 ± 0.87% (std=0.94) delta: 0.20%
* Latency p99: 339.99 ± 1.20% (std=2.89) delta: 2.41%
oltp_update_index:
* QPS: 4237.32 ± 0.19% (std=6.52) delta: 0.01% (p=0.406)
* Latency p50: 30.21 ± 0.19% (std=0.04) delta: -0.00%
* Latency p99: 53.37 ± 0.90% (std=0.48) delta: -2.68%
oltp_update_non_index:
* QPS: 4692.52 ± 0.77% (std=25.45) delta: -0.39% (p=0.300)
* Latency p50: 27.28 ± 0.78% (std=0.15) delta: 0.42%
* Latency p99: 43.13 ± 1.21% (std=0.37) delta: 3.06%
|
|
@breeswish How to handle the rolling update? |
lonng
reviewed
Jan 15, 2020
|
@lonng Our 3.0.x does not include Chunk format, so this change is fine. |
|
/run-all-tests tidb=pr/14278 tidb-test=pr/975 |
|
/bench +sysbench +tpch tidb=pr/14278 |
Benchmark Report
@@ Benchmark Diff @@
================================================================================
--- tidb: 1e9f90853f2cb45186906b2d47cde24b07e5a6a8
+++ tidb: 59e9ceb055866194842e75bb06c54acb6516425b
--- tikv: f6056959c8d1cfeb53def017aba3d9e2bf924927
+++ tikv: 70389a7c94ace75322baea413bb9d049bc6ea165
pd: d4c196eff51c8e358d9c8fc027665ec9c1309d2a
================================================================================
oltp_insert:
* QPS: 7352.24 ± 0.51% (std=24.77) delta: -1.35% (p=0.002)
* Latency p50: 17.41 ± 0.49% (std=0.06) delta: 1.38%
* Latency p99: 29.86 ± 4.00% (std=0.79) delta: 2.31%
oltp_point_select:
* QPS: 37678.92 ± 1.62% (std=375.28) delta: -0.70% (p=0.494)
* Latency p50: 3.40 ± 1.55% (std=0.03) delta: 0.59%
* Latency p99: 10.27 ± 0.00% (std=0.00) delta: -1.82%
oltp_read_write:
* QPS: 15814.13 ± 0.27% (std=25.74) delta: -0.31% (p=0.095)
* Latency p50: 162.06 ± 0.04% (std=0.05) delta: 0.20%
* Latency p99: 307.56 ± 4.10% (std=8.24) delta: 0.03%
oltp_update_index:
* QPS: 4241.73 ± 0.22% (std=7.70) delta: 0.09% (p=0.535)
* Latency p50: 30.17 ± 0.22% (std=0.06) delta: -0.08%
* Latency p99: 54.35 ± 2.71% (std=1.09) delta: -0.92%
oltp_update_non_index:
* QPS: 4729.65 ± 0.26% (std=10.33) delta: -0.06% (p=0.613)
* Latency p50: 27.06 ± 0.25% (std=0.06) delta: 0.06%
* Latency p99: 42.24 ± 4.56% (std=1.27) delta: -1.88%
|
Benchmark Report
@@ Benchmark Diff @@
================================================================================
--- tidb: 1e9f90853f2cb45186906b2d47cde24b07e5a6a8
+++ tidb: 59e9ceb055866194842e75bb06c54acb6516425b
--- tikv: f6056959c8d1cfeb53def017aba3d9e2bf924927
+++ tikv: 70389a7c94ace75322baea413bb9d049bc6ea165
pd: d4c196eff51c8e358d9c8fc027665ec9c1309d2a
================================================================================
01.sql duration: 19214.72 ms ± 3.08% (std=277.14) delta: 4.13% (p=0.220)
02.sql duration: 4451.48 ms ± 4.19% (std=106.69) delta: 3.28% (p=0.061)
03.sql duration: 14488.15 ms ± 2.90% (std=229.41) delta: 3.18% (p=0.001)
04.sql duration: 6961.56 ms ± 1.84% (std=83.94) delta: -0.51% (p=0.953)
06.sql duration: 9855.30 ms ± 7.56% (std=430.76) delta: 10.76% (p=0.001)
07.sql duration: 13099.72 ms ± 0.91% (std=80.95) delta: 1.41% (p=0.005)
08.sql duration: 12320.34 ms ± 1.90% (std=113.72) delta: 1.01% (p=0.017)
09.sql duration: 35917.90 ms ± 3.43% (std=617.44) delta: 1.94% (p=0.141)
10.sql duration: 10166.35 ms ± 1.57% (std=107.57) delta: 2.54% (p=0.060)
11.sql duration: 3423.50 ms ± 4.20% (std=94.53) delta: 10.36% (p=0.000)
12.sql duration: 11668.73 ms ± 6.96% (std=611.49) delta: 5.86% (p=0.023)
13.sql duration: 10453.00 ms ± 1.17% (std=73.04) delta: -0.51% (p=0.398)
14.sql duration: 10553.30 ms ± 3.44% (std=208.08) delta: 3.18% (p=0.020)
15.sql duration: 19133.95 ms ± 4.47% (std=506.24) delta: 2.82% (p=0.022)
16.sql duration: 3748.03 ms ± 4.71% (std=104.16) delta: 1.60% (p=0.142)
17.sql duration: 33986.26 ms ± 1.45% (std=317.05) delta: 0.65% (p=0.352)
18.sql duration: 50816.87 ms ± 8.70% (std=2786.02) delta: -4.33% (p=0.487)
19.sql duration: 12959.41 ms ± 1.09% (std=80.63) delta: 1.55% (p=0.804)
20.sql duration: 10772.80 ms ± 2.50% (std=209.07) delta: 5.27% (p=0.006)
21.sql duration: 26857.30 ms ± 0.47% (std=64.86) delta: 0.50% (p=0.178)
22.sql duration: 5409.42 ms ± 4.10% (std=127.01) delta: 0.06% (p=0.489) |
|
@sre-bot /bench +sysbench +tpch tidb=pr/14278 |
|
@TennyZhuang No command or invalid command |
|
@sre-bot /bench |
|
@sre-bot /bench +tpch tidb=pr/14278 |
|
/bench +tpch tidb=pr/14278 |
Benchmark Report
@@ Benchmark Diff @@
================================================================================
--- tidb: c2da4eafd7c6b7165ed72c5890e18917cde8ffc9
+++ tidb: 84111c1ff9e755f3d191ed18f0934c2959d96c29
--- tikv: d89c0ff8f16224d23aad142375543313c632b6c4
+++ tikv: 1fda332f97cd7042316fb38be12cde1c86474094
pd: 865ac28eda39f1679ab7aabed773f1cd7c95faa8
================================================================================
16.sql duration: 3914.58 ms ± 11.12% (std=313.29) delta: 13.52% (p=0.697) |
|
@sre-bot /bench +tpch tidb=pr/14278
workload:
queries: 16.sql
repeat_time: 5
pingcap-github-bot <notifications@github.com>于2020年1月27日 周一10:01写道：
… Benchmark Report
Run TPC-H 10G Performance Test on VMs
@@ Benchmark Diff @@
================================================================================
--- tidb: c2da4eafd7c6b7165ed72c5890e18917cde8ffc9
+++ tidb: 84111c1ff9e755f3d191ed18f0934c2959d96c29
--- tikv: d89c0ff
+++ tikv: 1fda332
pd: 865ac28eda39f1679ab7aabed773f1cd7c95faa8
================================================================================
16.sql duration: 3914.58 ms ± 11.12% (std=313.29) delta: 13.52% (p=0.697)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6418?email_source=notifications&email_token=ACF4VXUZ42DNCS6HKBYENFDQ7Y57LA5CNFSM4KDACPA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJ6EIRQ#issuecomment-578569286>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACF4VXVBGOJW5WVDI7KFJ7DQ7Y57LANCNFSM4KDACPAQ>
.
|
|
/bench +tpch tidb=pr/14278 workload: pingcap-github-bot notifications@github.com于2020年1月27日 周一10:01写道：
|
|
/bench +tpch tidb=pr/14278 |
|
@sre-bot /bench +tpch tidb=pr/14278 |
1 similar comment
|
@sre-bot /bench +tpch tidb=pr/14278 |
Benchmark Report
@@ Benchmark Diff @@
================================================================================
--- tidb: c2da4eafd7c6b7165ed72c5890e18917cde8ffc9
+++ tidb: 84111c1ff9e755f3d191ed18f0934c2959d96c29
--- tikv: d89c0ff8f16224d23aad142375543313c632b6c4
+++ tikv: 1fda332f97cd7042316fb38be12cde1c86474094
pd: 865ac28eda39f1679ab7aabed773f1cd7c95faa8
================================================================================
01.sql duration: 19031.28 ms ± 4.16% (std=358.79) delta: 0.52% (p=0.736)
02.sql duration: 4529.44 ms ± 3.97% (std=96.20) delta: 5.14% (p=0.011)
03.sql duration: 13999.77 ms ± 0.68% (std=57.36) delta: 1.88% (p=0.061)
04.sql duration: 7090.39 ms ± 3.14% (std=136.52) delta: 2.67% (p=0.046)
06.sql duration: 9068.79 ms ± 1.49% (std=77.15) delta: 1.22% (p=0.886)
07.sql duration: 13162.32 ms ± 0.60% (std=39.64) delta: 2.59% (p=0.000)
08.sql duration: 12758.98 ms ± 2.54% (std=224.44) delta: 4.82% (p=0.000)
09.sql duration: 35258.37 ms ± 1.39% (std=287.90) delta: -0.29% (p=0.534)
10.sql duration: 10011.68 ms ± 1.15% (std=69.84) delta: 1.92% (p=0.140)
11.sql duration: 3261.25 ms ± 5.81% (std=87.41) delta: 4.74% (p=0.002)
12.sql duration: 11617.19 ms ± 2.87% (std=217.86) delta: 4.60% (p=0.098)
13.sql duration: 10268.16 ms ± 2.61% (std=162.94) delta: -0.86% (p=0.695)
14.sql duration: 10285.95 ms ± 2.83% (std=129.47) delta: 3.27% (p=0.185)
15.sql duration: 19732.30 ms ± 4.28% (std=512.18) delta: 5.51% (p=0.034)
16.sql duration: 3668.61 ms ± 15.05% (std=271.14) delta: -1.19% (p=0.360)
17.sql duration: 34543.07 ms ± 2.17% (std=452.60) delta: 3.65% (p=0.000)
18.sql duration: 48364.49 ms ± 1.57% (std=471.96) delta: -5.32% (p=0.093)
19.sql duration: 14422.85 ms ± 6.60% (std=660.99) delta: 13.69% (p=0.001)
20.sql duration: 10428.04 ms ± 2.62% (std=164.98) delta: -0.63% (p=0.333)
21.sql duration: 26956.31 ms ± 0.12% (std=17.95) delta: 1.05% (p=0.000)
22.sql duration: 5443.09 ms ± 5.11% (std=168.86) delta: 2.21% (p=0.040) |
|
@sre-bot /bench +tpch tidb=pr/14278 |
|
/bench +tpch tidb=pr/14278 |
Benchmark Report
@@ Benchmark Diff @@
================================================================================
--- tidb: c2da4eafd7c6b7165ed72c5890e18917cde8ffc9
+++ tidb: 3f13aa8793e731d6b1ef4c8dade316afaa8f531c
--- tikv: d89c0ff8f16224d23aad142375543313c632b6c4
+++ tikv: 1fda332f97cd7042316fb38be12cde1c86474094
pd: 865ac28eda39f1679ab7aabed773f1cd7c95faa8
================================================================================
19.sql duration: 13442.27 ms ± 7.22% (std=710.74) delta: 6.38% (p=0.193) |
|
/bench +tpch tidb=pr/14278 |
|
/bench +tpch tidb=pr/14278 |
Benchmark Report
@@ Benchmark Diff @@
================================================================================
--- tidb: 24b6e615d7ede02d02e38035e95496c6a6f36860
+++ tidb: 3f13aa8793e731d6b1ef4c8dade316afaa8f531c
--- tikv: d89c0ff8f16224d23aad142375543313c632b6c4
+++ tikv: 1fda332f97cd7042316fb38be12cde1c86474094
pd: 865ac28eda39f1679ab7aabed773f1cd7c95faa8
================================================================================
01.sql duration: 18933.40 ms ± 2.22% (std=251.74) delta: 2.03% (p=0.388)
02.sql duration: 4461.56 ms ± 3.05% (std=86.17) delta: 4.00% (p=0.022)
03.sql duration: 14549.12 ms ± 2.89% (std=214.27) delta: 3.92% (p=0.000)
04.sql duration: 7197.29 ms ± 3.19% (std=131.74) delta: -0.27% (p=0.870)
06.sql duration: 9576.68 ms ± 7.61% (std=365.37) delta: 9.02% (p=0.003)
07.sql duration: 13118.19 ms ± 1.14% (std=98.17) delta: 1.34% (p=0.009)
08.sql duration: 12259.43 ms ± 1.11% (std=81.40) delta: 0.56% (p=0.338)
09.sql duration: 35633.51 ms ± 1.31% (std=269.90) delta: 1.91% (p=0.003)
10.sql duration: 10346.93 ms ± 2.50% (std=165.19) delta: 4.56% (p=0.001)
11.sql duration: 3160.31 ms ± 4.60% (std=67.51) delta: 2.45% (p=0.320)
12.sql duration: 11234.58 ms ± 4.23% (std=212.73) delta: 0.02% (p=0.540)
13.sql duration: 10304.35 ms ± 2.76% (std=157.63) delta: -0.26% (p=0.773)
14.sql duration: 10350.87 ms ± 8.41% (std=481.81) delta: 4.36% (p=0.118)
15.sql duration: 19125.52 ms ± 4.40% (std=433.15) delta: 3.73% (p=0.024)
16.sql duration: 3823.61 ms ± 10.39% (std=210.13) delta: 1.37% (p=0.329)
17.sql duration: 34934.12 ms ± 2.14% (std=468.94) delta: 5.50% (p=0.000)
18.sql duration: 49006.41 ms ± 3.12% (std=959.11) delta: -0.11% (p=0.212)
19.sql duration: 13026.22 ms ± 1.58% (std=115.76) delta: 2.64% (p=0.309)
20.sql duration: 10296.56 ms ± 1.77% (std=107.66) delta: -0.59% (p=0.329)
21.sql duration: 27444.78 ms ± 0.18% (std=29.14) delta: 2.23% (p=0.000)
22.sql duration: 5330.78 ms ± 0.90% (std=28.08) delta: -0.50% (p=0.946) |
|
/bench +tpch tidb=pr/14278 |
|
@sre-bot /bench +tpch tidb=pr/14278 |
|
/bench +tpch tidb=pr/14278 |
Benchmark Report
@@ Benchmark Diff @@
================================================================================
--- tidb: 24b6e615d7ede02d02e38035e95496c6a6f36860
+++ tidb: 3f13aa8793e731d6b1ef4c8dade316afaa8f531c
--- tikv: d89c0ff8f16224d23aad142375543313c632b6c4
+++ tikv: 1fda332f97cd7042316fb38be12cde1c86474094
pd: 865ac28eda39f1679ab7aabed773f1cd7c95faa8
================================================================================
06.sql duration: 9097.30 ms ± 1.03% (std=52.02) delta: 2.01% (p=0.169) |
|
/bench +tpch tidb=pr/14278 |
breezewish
approved these changes
Jan 29, 2020
Benchmark Report
@@ Benchmark Diff @@
================================================================================
--- tidb: 24b6e615d7ede02d02e38035e95496c6a6f36860
+++ tidb: 3f13aa8793e731d6b1ef4c8dade316afaa8f531c
--- tikv: d89c0ff8f16224d23aad142375543313c632b6c4
+++ tikv: 1fda332f97cd7042316fb38be12cde1c86474094
pd: 865ac28eda39f1679ab7aabed773f1cd7c95faa8
================================================================================
01.sql duration: 18976.05 ms ± 3.68% (std=338.09) delta: 2.73% (p=0.029)
02.sql duration: 4362.50 ms ± 5.24% (std=106.67) delta: 1.19% (p=0.207)
03.sql duration: 14620.22 ms ± 2.07% (std=196.32) delta: 5.76% (p=0.001)
04.sql duration: 7426.15 ms ± 1.42% (std=66.61) delta: 2.04% (p=0.046)
06.sql duration: 9388.54 ms ± 7.98% (std=446.01) delta: 7.59% (p=0.002)
07.sql duration: 13038.93 ms ± 0.90% (std=80.17) delta: 2.03% (p=0.007)
08.sql duration: 12789.31 ms ± 1.96% (std=142.43) delta: 4.19% (p=0.000)
09.sql duration: 35080.79 ms ± 0.47% (std=113.06) delta: -1.01% (p=0.788)
10.sql duration: 9891.60 ms ± 5.47% (std=317.58) delta: -0.05% (p=0.497)
11.sql duration: 3309.45 ms ± 2.89% (std=62.10) delta: 6.08% (p=0.000)
12.sql duration: 11536.95 ms ± 1.49% (std=119.83) delta: 2.52% (p=0.177)
13.sql duration: 10407.68 ms ± 2.24% (std=165.89) delta: 0.85% (p=0.543)
14.sql duration: 10262.63 ms ± 1.20% (std=59.45) delta: 3.44% (p=0.000)
15.sql duration: 19192.05 ms ± 3.40% (std=403.47) delta: 3.35% (p=0.061)
16.sql duration: 3678.62 ms ± 12.94% (std=319.80) delta: -0.65% (p=0.473)
17.sql duration: 33746.18 ms ± 2.03% (std=421.27) delta: 1.19% (p=0.140)
18.sql duration: 50255.66 ms ± 3.84% (std=1301.08) delta: 2.44% (p=0.045)
19.sql duration: 12993.58 ms ± 0.87% (std=65.77) delta: 2.49% (p=0.302)
20.sql duration: 10769.40 ms ± 4.97% (std=307.26) delta: 4.89% (p=0.054)
21.sql duration: 26870.00 ms ± 0.86% (std=114.55) delta: -1.58% (p=0.000)
22.sql duration: 5377.07 ms ± 3.10% (std=119.40) delta: 0.25% (p=0.419) |
|
/run-all-tests tidb=pr/14278 |
|
/run-all-tests tidb=pr/14278 tidb-test=pr/975 |
|
/run-integration-common-test tidb=pr/14278 tidb-test=pr/975 |
c1ay
pushed a commit
to c1ay/tikv
that referenced
this pull request
May 9, 2020
Signed-off-by: TennyZhuang <zty0826@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: TennyZhuang zty0826@gmail.com
What have you changed?
Use new 8 byte chunk time format.
What is the type of the changes?
How is the PR tested?
Refer to a related PR or issue link (optional)
Related to pingcap/tidb#14278
Benchmark result if necessary (optional)
Any examples? (optional)