Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup fingerprint issue in Dockerfile #6455

Merged
merged 8 commits into from Jan 18, 2020
Merged

Conversation

Hoverbear
Copy link
Contributor

Signed-off-by: Ana Hobden operator@hoverbear.org

What have you changed?

Fix a small problem originating from a late change in #6408 that could result in a bad build.

What is the type of the changes?

  • Bugfix (a change which fixes an issue)

How is the PR tested?

  • Manual test (add detailed scripts or steps below)

Does this PR affect documentation (docs) or should it be mentioned in the release notes?

Does this PR affect tidb-ansible?

Refer to a related PR or issue link (optional)

Benchmark result if necessary (optional)

Any examples? (optional)

Signed-off-by: Ana Hobden <operator@hoverbear.org>
@Hoverbear Hoverbear added component/build Component: Build, Deployment, etc. type/bugfix Type: PR - Fix a bug labels Jan 10, 2020
@Hoverbear Hoverbear self-assigned this Jan 10, 2020
Copy link
Contributor

@zhouqiang-cl zhouqiang-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hoverbear
Copy link
Contributor Author

@glorv ptal

Copy link
Contributor

@glorv glorv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hoverbear
Copy link
Contributor Author

/merge

@sre-bot sre-bot added the status/can-merge Status: Can merge to base branch label Jan 13, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jan 13, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jan 13, 2020

@Hoverbear merge failed.

@Hoverbear
Copy link
Contributor Author

/retest

@Hoverbear
Copy link
Contributor Author

/run-all-tests

@Hoverbear
Copy link
Contributor Author

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Jan 15, 2020

/run-all-tests

@youjiali1995
Copy link
Contributor

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Jan 16, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jan 16, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jan 16, 2020

@Hoverbear merge failed.

@youjiali1995
Copy link
Contributor

/test

@Hoverbear
Copy link
Contributor Author

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Jan 17, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jan 17, 2020

@Hoverbear merge failed.

@youjiali1995
Copy link
Contributor

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Jan 17, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jan 17, 2020

@Hoverbear merge failed.

@Hoverbear
Copy link
Contributor Author

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Jan 17, 2020

Your auto merge job has been accepted, waiting for 6454, 6454

@sre-bot
Copy link
Contributor

sre-bot commented Jan 17, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jan 17, 2020

@Hoverbear merge failed.

@Hoverbear
Copy link
Contributor Author

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Jan 17, 2020

/run-all-tests

Copy link
Contributor

@zhouqiang-cl zhouqiang-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hoverbear
Copy link
Contributor Author

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Jan 18, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jan 18, 2020

@Hoverbear merge failed.

@Hoverbear
Copy link
Contributor Author

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Jan 18, 2020

/run-all-tests

@sre-bot sre-bot merged commit 6ab58f9 into tikv:master Jan 18, 2020
c1ay pushed a commit to c1ay/tikv that referenced this pull request May 9, 2020
Signed-off-by: Ana Hobden <operator@hoverbear.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/build Component: Build, Deployment, etc. status/can-merge Status: Can merge to base branch type/bugfix Type: PR - Fix a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants