Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bin: slog use block strategy #6547

Merged
merged 1 commit into from Feb 13, 2020
Merged

Conversation

overvenus
Copy link
Member

What have you changed?

Fix missing logs by using OverflowStrategy::Block strategy.

What is the type of the changes?

  • Bugfix (a change which fixes an issue)

How is the PR tested?

N/A

Does this PR affect documentation (docs) or should it be mentioned in the release notes?

Yes

Does this PR affect tidb-ansible?

No.

Signed-off-by: Neil Shen <overvenus@gmail.com>
@overvenus overvenus added type/bugfix Type: PR - Fix a bug type/changelog Type: PR - Need to be noted in the CHANGELOG labels Feb 7, 2020
@overvenus overvenus added this to the v2.1.20 milestone Feb 7, 2020
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youjiali1995 youjiali1995 merged commit edb89bb into tikv:release-2.1 Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bugfix Type: PR - Fix a bug type/changelog Type: PR - Need to be noted in the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants