cdc: check leadership before subscribing #6691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
overvenus
reviewed
Feb 26, 2020
components/cdc/src/endpoint.rs
Outdated
| @@ -101,6 +101,7 @@ impl fmt::Debug for Task { | |||
| } | |||
|
|
|||
| pub struct Endpoint { | |||
| // TODO: add RaftRouter here. | |||
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
|
I will submit another PR for reorganizing the tests of cdc after this one is landed. |
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
overvenus
reviewed
Feb 27, 2020
components/cdc/src/endpoint.rs
Outdated
| capture_regions: HashMap<u64, Delegate>, | ||
| scheduler: Scheduler<Task>, | ||
| apply_router: ApplyRouter, | ||
| casual_router: T, |
There was a problem hiding this comment.
Could you name it to raft_router? casual_router sounds confusing.
components/cdc/src/endpoint.rs
Outdated
| @@ -257,6 +269,11 @@ impl Endpoint { | |||
| fn on_region_ready(&mut self, region_id: u64, resolver: Resolver, region: Region) { | |||
| if let Some(delegate) = self.capture_regions.get_mut(®ion_id) { | |||
| delegate.on_region_ready(resolver, region); | |||
| println!("region ready: has_failed({})", delegate.has_failed()); | |||
components/cdc/src/endpoint.rs
Outdated
| cb: Callback::Read(Box::new(move |resp: ReadResponse<_>| { | ||
| } | ||
| }; | ||
| if let Err(e) = self.casual_router.send( |
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
MyonKeminta
reviewed
Mar 2, 2020
| } | ||
| self.ctx | ||
| .apply_router | ||
| .schedule_task(self.region_id(), ApplyTask::Change { cmd, cb }) |
There was a problem hiding this comment.
Is it possible that the leader changes after this but before the cmd is executed?
There was a problem hiding this comment.
Yes, but role change events will be caught by the cdc observer.
|
/run-all-tests |
zhangjinpeng87
pushed a commit
to zhangjinpeng87/tikv
that referenced
this pull request
Mar 26, 2020
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
c1ay
pushed a commit
to c1ay/tikv
that referenced
this pull request
May 9, 2020
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: 5kbpers tangminghua@pingcap.com
What have you changed?
Add
CasualMessage::CaptureChangefor checking leadership before starting to subscribe changes of a region.What is the type of the changes?
How is the PR tested?
Does this PR affect documentation (docs) or should it be mentioned in the release notes?
No.
Does this PR affect
tidb-ansible?No.