Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raftstore/hibernate: wake up on proposal #6736

Merged
merged 3 commits into from
Feb 28, 2020

Conversation

BusyJay
Copy link
Member

@BusyJay BusyJay commented Feb 28, 2020

What have you changed?

#6672 breaks hibernate regions by not waking leader up on proposal accidentally. This PR fixes by setting all the missing flags.

What is the type of the changes?

  • Bugfix

How is the PR tested?

  • Integration test

Does this PR affect documentation (docs) or should it be mentioned in the release notes?

No.

Does this PR affect tidb-ansible?

No.

Refer to a related PR or issue link (optional)

#6672

Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
@BusyJay BusyJay added sig/raft Component: Raft, RaftStore, etc. type/bugfix Type: PR - Fix a bug labels Feb 28, 2020
@BusyJay BusyJay added needs-cherry-pick-release-3.0 Type: Need cherry pick to release 3.0 needs-cherry-pick-release-3.1 Type: Need cherry pick to release 3.1 labels Feb 28, 2020
@BusyJay
Copy link
Member Author

BusyJay commented Feb 28, 2020

I think the fail case is probably fixed by #6648.

@BusyJay BusyJay added the status/can-merge Status: Can merge to base branch label Feb 28, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Feb 28, 2020

/run-all-tests

@sre-bot sre-bot merged commit 6ef8f24 into tikv:master Feb 28, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Feb 28, 2020

cherry pick to release-3.0 failed

@sre-bot
Copy link
Contributor

sre-bot commented Feb 28, 2020

cherry pick to release-3.1 failed

@BusyJay BusyJay deleted the fix-hibernate-proposal branch February 28, 2020 16:06
BusyJay added a commit to BusyJay/tikv that referenced this pull request Feb 28, 2020
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
@BusyJay BusyJay mentioned this pull request Feb 28, 2020
BusyJay added a commit to BusyJay/tikv that referenced this pull request Feb 28, 2020
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
BusyJay added a commit to BusyJay/tikv that referenced this pull request Feb 28, 2020
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
BusyJay added a commit to BusyJay/tikv that referenced this pull request Feb 28, 2020
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
BusyJay added a commit to BusyJay/tikv that referenced this pull request Feb 28, 2020
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
BusyJay added a commit to BusyJay/tikv that referenced this pull request Feb 28, 2020
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
BusyJay added a commit to BusyJay/tikv that referenced this pull request Feb 28, 2020
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
BusyJay added a commit to BusyJay/tikv that referenced this pull request Feb 28, 2020
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
youjiali1995 pushed a commit that referenced this pull request Feb 29, 2020
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
youjiali1995 pushed a commit that referenced this pull request Feb 29, 2020
* raftstore/hibernate: wake up for more cases (#6672)
* raftstore/hibernate: wake up on proposal (#6736)
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
solotzg pushed a commit to pingcap/tidb-engine-ext that referenced this pull request Feb 29, 2020
* raftstore/hibernate: wake up for more cases (tikv#6672)
* raftstore/hibernate: wake up on proposal (tikv#6736)
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
solotzg pushed a commit to pingcap/tidb-engine-ext that referenced this pull request Feb 29, 2020
* raftstore/hibernate: wake up for more cases (tikv#6672)
* raftstore/hibernate: wake up on proposal (tikv#6736)
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
zhangjinpeng87 pushed a commit to zhangjinpeng87/tikv that referenced this pull request Mar 26, 2020
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
c1ay pushed a commit to c1ay/tikv that referenced this pull request May 9, 2020
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-3.0 Type: Need cherry pick to release 3.0 needs-cherry-pick-release-3.1 Type: Need cherry pick to release 3.1 sig/raft Component: Raft, RaftStore, etc. status/can-merge Status: Can merge to base branch type/bugfix Type: PR - Fix a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants