Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add github workflow to auto-assign failed test issue to solid tests project #7102

Merged
merged 4 commits into from Mar 16, 2020

Conversation

glorv
Copy link
Contributor

@glorv glorv commented Mar 16, 2020

Signed-off-by: glorv glorvs@163.com

What have you changed?

We have created a daily report job to find tests on our CI that fails occasionnally and auto create issures for them. This github workflow will auto assign these issues to Solid Tests project so we can manage them easier.

Similar workflow for tidb is here

  • Summarize your change

Don't assume reviewers understand the original issue.

What is the type of the changes?

  • Misc (other changes)

How is the PR tested?

Signed-off-by: glorv <glorvs@163.com>
@glorv glorv requested a review from mahjonp March 16, 2020 07:14
Signed-off-by: glorv <glorvs@163.com>
Signed-off-by: glorv <glorvs@163.com>
@glorv glorv requested a review from you06 March 16, 2020 07:42
- name: Run issues assignment to project Solid Tests Kanban
uses: srggrs/assign-one-project-github-action@1.2.0
if: |
github.event.issue.user.login == 'sre-bot' &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it mean only issues created by bot will be added into the target project?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. Issues create by sre-bot with bench-test label are done by our daily report job, so these issues can be auto-added to the Solid Tests. I'm not sure if there are some other conditions, we should also do this. @mahjonp PTAL

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why can't bot do it directly?

Copy link
Contributor

@you06 you06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mahjonp mahjonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mahjonp
Copy link
Contributor

mahjonp commented Mar 16, 2020

/merge

@sre-bot sre-bot added the status/can-merge Status: Can merge to base branch label Mar 16, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 16, 2020

/run-all-tests

@sre-bot sre-bot merged commit 8ce5e98 into tikv:master Mar 16, 2020
zhangjinpeng87 pushed a commit to zhangjinpeng87/tikv that referenced this pull request Mar 26, 2020
…ests project (tikv#7102)

Signed-off-by: glorv <glorvs@163.com>
c1ay pushed a commit to c1ay/tikv that referenced this pull request May 9, 2020
…ests project (tikv#7102)

Signed-off-by: glorv <glorvs@163.com>
@glorv glorv deleted the failed-test-workflow branch November 23, 2022 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Status: Can merge to base branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants