New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
encryption: support AWS KMS backend #7173
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
yiwu-arbug
reviewed
Mar 23, 2020
yiwu-arbug
reviewed
Mar 24, 2020
yiwu-arbug
reviewed
Mar 25, 2020
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
yiwu-arbug
approved these changes
Mar 31, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Merge with #7173 and we are good to go.
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
Signed-off-by: Neil Shen <overvenus@gmail.com>
/run-all-tests |
hicqu
approved these changes
Apr 4, 2020
overvenus
added a commit
to overvenus/tikv
that referenced
this pull request
Apr 15, 2020
* encryption: basic AWS KMS support Signed-off-by: Neil Shen <overvenus@gmail.com> * encryption: add encryption cli Signed-off-by: Neil Shen <overvenus@gmail.com> * encryptoin: generate master from KMS Signed-off-by: Neil Shen <overvenus@gmail.com> * encryption: refine encryption cli Signed-off-by: Neil Shen <overvenus@gmail.com> * encryption: add KMS vendor to metadata Signed-off-by: Neil Shen <overvenus@gmail.com> * encryption: upgrade rusoto_kms Signed-off-by: Neil Shen <overvenus@gmail.com> * encryption: use structopt instead of clap Signed-off-by: Neil Shen <overvenus@gmail.com> * encryption: add license header Signed-off-by: Neil Shen <overvenus@gmail.com> * encryption: use rusoto util to create KMS client Signed-off-by: Neil Shen <overvenus@gmail.com> * encryption: share common encrytion backend between file and kms Signed-off-by: Neil Shen <overvenus@gmail.com> * encryption: attach ciphertext key to metdata Signed-off-by: Neil Shen <overvenus@gmail.com> * encryption: add kms config test Signed-off-by: Neil Shen <overvenus@gmail.com>
overvenus
added a commit
to overvenus/tikv
that referenced
this pull request
Apr 15, 2020
* encryption: basic AWS KMS support Signed-off-by: Neil Shen <overvenus@gmail.com> * encryption: add encryption cli Signed-off-by: Neil Shen <overvenus@gmail.com> * encryptoin: generate master from KMS Signed-off-by: Neil Shen <overvenus@gmail.com> * encryption: refine encryption cli Signed-off-by: Neil Shen <overvenus@gmail.com> * encryption: add KMS vendor to metadata Signed-off-by: Neil Shen <overvenus@gmail.com> * encryption: upgrade rusoto_kms Signed-off-by: Neil Shen <overvenus@gmail.com> * encryption: use structopt instead of clap Signed-off-by: Neil Shen <overvenus@gmail.com> * encryption: add license header Signed-off-by: Neil Shen <overvenus@gmail.com> * encryption: use rusoto util to create KMS client Signed-off-by: Neil Shen <overvenus@gmail.com> * encryption: share common encrytion backend between file and kms Signed-off-by: Neil Shen <overvenus@gmail.com> * encryption: attach ciphertext key to metdata Signed-off-by: Neil Shen <overvenus@gmail.com> * encryption: add kms config test Signed-off-by: Neil Shen <overvenus@gmail.com>
c1ay
pushed a commit
to c1ay/tikv
that referenced
this pull request
May 9, 2020
* encryption: basic AWS KMS support Signed-off-by: Neil Shen <overvenus@gmail.com> * encryption: add encryption cli Signed-off-by: Neil Shen <overvenus@gmail.com> * encryptoin: generate master from KMS Signed-off-by: Neil Shen <overvenus@gmail.com> * encryption: refine encryption cli Signed-off-by: Neil Shen <overvenus@gmail.com> * encryption: add KMS vendor to metadata Signed-off-by: Neil Shen <overvenus@gmail.com> * encryption: upgrade rusoto_kms Signed-off-by: Neil Shen <overvenus@gmail.com> * encryption: use structopt instead of clap Signed-off-by: Neil Shen <overvenus@gmail.com> * encryption: add license header Signed-off-by: Neil Shen <overvenus@gmail.com> * encryption: use rusoto util to create KMS client Signed-off-by: Neil Shen <overvenus@gmail.com> * encryption: share common encrytion backend between file and kms Signed-off-by: Neil Shen <overvenus@gmail.com> * encryption: attach ciphertext key to metdata Signed-off-by: Neil Shen <overvenus@gmail.com> * encryption: add kms config test Signed-off-by: Neil Shen <overvenus@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed?
Using AWS KMS service to encrypt and decrypt key dict.
What is the type of the changes?
How is the PR tested?
Does this PR affect documentation (docs) or should it be mentioned in the release notes?
Yes.
Does this PR affect
tidb-ansible
?No.