txn: PessimisticLock with min_commit_ts #7291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youjiali1995
added
sig/transaction
Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
youjiali1995
force-pushed
the
push-pessimistic-locks-min-commit-ts
branch
from
f47c2ce
to
a62d6df
Compare
|
@sticnarf PTAL |
Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
|
/merge |
|
/run-all-tests |
|
cherry pick to release-4.0 in PR #7328 |
sre-bot
added a commit
that referenced
this pull request
Apr 8, 2020
c1ay
pushed a commit
to c1ay/tikv
that referenced
this pull request
May 9, 2020
Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: youjiali1995 zlwgx1023@gmail.com
What problem does this PR solve?
Issue Number: close #7289
Problem Summary:
If the primary lock is pessimistic lock and some secondary locks are optimistic locks, these secondary locks will block reads because the pessimistic lock can't be pushed its commit ts.
What is changed and how it works?
What's Changed:
Add
min_commit_tsfield to pessimistic locks andcheck_txn_statuscan push forward it.kvproto: pingcap/kvproto#588
Related changes
Check List
Tests
Side effects
Release note
An issue that optimistic locks may blocks reads if the corresponding primary lock is a pessimistic lock has been fixed.