Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: fix wrong write size of resolve lock #7590

Merged
merged 2 commits into from
Apr 22, 2020

Conversation

youjiali1995
Copy link
Contributor

Signed-off-by: youjiali1995 zlwgx1023@gmail.com

What problem does this PR solve?

Problem Summary:
Now we use one MvccTxn to process resolve lock requests. The write size shouldn't be accumulated.

What is changed and how it works?

What's Changed:
Don't accumulate write size of resolve lock.

Related changes

It's introduced in #7379. I have fixed it when cherry pick it to release branches, so needn't cherry pick this PR.

Check List

Tests

  • No code

Release note

Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
@youjiali1995 youjiali1995 added component/storage Component: Storage, Scheduler, etc. type/bugfix Type: PR - Fix a bug labels Apr 21, 2020
Copy link
Contributor

@nrc nrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@youjiali1995
Copy link
Contributor Author

/merge

1 similar comment
@youjiali1995
Copy link
Contributor Author

/merge

@sre-bot sre-bot added the status/can-merge Status: Can merge to base branch label Apr 22, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Apr 22, 2020

/run-all-tests

@sre-bot sre-bot merged commit 848cdd2 into tikv:master Apr 22, 2020
@youjiali1995 youjiali1995 deleted the fix-write-size-of-resolve-lock branch April 23, 2020 01:31
c1ay pushed a commit to c1ay/tikv that referenced this pull request May 9, 2020
Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/storage Component: Storage, Scheduler, etc. status/can-merge Status: Can merge to base branch type/bugfix Type: PR - Fix a bug
Projects
Transaction SIG
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

4 participants