add edition field for the version information #7821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zhangjinpeng1987 <zhangjinpeng@pingcap.com>
zhangjinpeng87
added
the
needs-cherry-pick-release-4.0
BusyJay
reviewed
May 13, 2020
src/lib.rs
Outdated
| @@ -66,15 +66,18 @@ pub mod storage; | |||
| /// Returns the tikv version information. | |||
| pub fn tikv_version_info() -> String { | |||
| let fallback = "Unknown (env var does not exist when building)"; | |||
| let edition = "Community"; | |||
There was a problem hiding this comment.
How to define values other than community?
Signed-off-by: zhangjinpeng1987 <zhangjinpeng@pingcap.com>
…into community-edition
Signed-off-by: zhangjinpeng1987 <zhangjinpeng@pingcap.com>
|
It's better to use the |
BusyJay
approved these changes
May 13, 2020
hicqu
approved these changes
May 13, 2020
I think it's better to keep the existing style. |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
/run-all-tests |
|
@zhangjinpeng1987 merge failed. |
|
/merge |
|
/run-all-tests |
sre-bot
pushed a commit
to sre-bot/tikv
that referenced
this pull request
May 13, 2020
Signed-off-by: zhangjinpeng1987 <zhangjinpeng@pingcap.com>
|
cherry pick to release-4.0 in PR #7831 |
zhangjinpeng87
pushed a commit
that referenced
this pull request
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: zhangjinpeng1987 zhangjinpeng@pingcap.com
What problem does this PR solve?
Add the edition field for the version information.
What is changed and how it works?
Add the edition field for the version information.
Related changes
Check List
Tests
Side effects
Release note