Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tikv-ctl used via relative path when encryption is enabled #7936

Merged
merged 2 commits into from May 26, 2020

Conversation

hunterlxt
Copy link
Member

Signed-off-by: TXXT hunterlxt@live.com

What problem does this PR solve?

close #7886

Problem Summary:
relative path cannot be key in encryption dictionary, let's canonicalize it.

What is changed and how it works?

canonicalize kv_path and raft_path

Related changes

None

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Side effects

No

Release note

  • Fix bug where tikv-ctl does not support relative path

Signed-off-by: TXXT <hunterlxt@live.com>
@hunterlxt hunterlxt added type/bugfix Type: PR - Fix a bug needs-cherry-pick-release-4.0 Type: Need cherry pick to release 4.0 labels May 25, 2020
@hunterlxt hunterlxt self-assigned this May 25, 2020
Copy link
Member

@zhangjinpeng87 zhangjinpeng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhangjinpeng87
Copy link
Member

/merge

@sre-bot sre-bot added the status/can-merge Status: Can merge to base branch label May 26, 2020
@sre-bot
Copy link
Contributor

sre-bot commented May 26, 2020

/run-all-tests

@sre-bot sre-bot merged commit b0e35f3 into tikv:master May 26, 2020
@zhangjinpeng87 zhangjinpeng87 added this to the v4.0.0 milestone May 26, 2020
@hunterlxt hunterlxt deleted the XT/make-tikv-ctl-work-again branch May 26, 2020 11:54
@yiwu-arbug yiwu-arbug removed this from the v4.0.0-ga milestone May 29, 2020
@yiwu-arbug
Copy link
Contributor

/run-cherry-picker

sre-bot pushed a commit to sre-bot/tikv that referenced this pull request May 29, 2020
@sre-bot
Copy link
Contributor

sre-bot commented May 29, 2020

cherry pick to release-4.0 in PR #7963

sre-bot added a commit that referenced this pull request Jun 4, 2020
@yiwu-arbug yiwu-arbug added the sig/engine SIG: Engine label Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-4.0 Type: Need cherry pick to release 4.0 sig/engine SIG: Engine status/can-merge Status: Can merge to base branch type/bugfix Type: PR - Fix a bug
Projects
Development

Successfully merging this pull request may close these issues.

tikv-ctl can't work when encryption is enabled
5 participants