copr: fix precision lost in json numeric comparsion (#8068) #8087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
/run-all-tests |
sre-bot
added
sig/coprocessor
breezewish
approved these changes
Jun 12, 2020
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
iosmanthus
approved these changes
Jun 12, 2020
|
/run-all-tests |
|
Sorry @Connor1996, you don't have permission to trigger auto merge event on this branch. |
|
/merge |
|
Sorry @Connor1996, you don't have permission to trigger auto merge event on this branch. |
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@sre-bot merge failed. |
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #8068 to release-4.0
Signed-off-by: Iosmanthus Teng myosmanthustree@gmail.com
What problem does this PR solve?
Fix pingcap/tidb#16267 along with pingcap/tidb#17622
while comparing JSON numeric value, tikv/tidb used to convert them into the double type and then do the comparison which facing precision lost if the number is large enough and lead to unexpected comparsion result.
Check List
Tests
Release note