backup,config: set backup thread pool size via config instead of gRPC (#8193) #8199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
/run-all-tests |
ti-srebot
added
component/backup-restore
|
@kennytm please accept the invitation then you can push to the cherry-pick pull requests. |
|
Please fix the conflicts. |
Signed-off-by: kennytm <kennytm@gmail.com>
|
/run-integration-compatibility-test |
kennytm
requested review from
overvenus and
NingLin-P
and removed request for
overvenus
NingLin-P
approved these changes
Jul 13, 2020
|
/run-integration-ddl-test |
overvenus
approved these changes
Jul 14, 2020
|
/run-integration-br-test |
|
/merge |
|
/run-all-tests |
lichunzhu
added a commit
to lichunzhu/tidb-operator
that referenced
this pull request
Jul 16, 2020
DanielZhangQD
added a commit
to pingcap/tidb-operator
that referenced
this pull request
Jul 17, 2020
* add pd EnableTelemetry argument, related PR: tikv/pd#2654 * add tikv backup config, related PR: tikv/tikv#8199 * re-generate code * address comments * address comment Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #8193 to release-4.0
What problem does this PR solve?
Issue Number: close pingcap/br#394, close #8076.
Problem Summary:
What is changed and how it works?
This is the companion PR of pingcap/br#396.
In #5553, the
backupcomponent gained ability to an adjustable thread pool size. The size is provided via the incoming gRPC request. Given how the ThreadPool is implemented in TiKV, a user can easily (accidentally) DoS all TiKV servers by setting the thread pool size to a huge number like 232-1.Furthermore, when we provide the thread pool size through gRPC, the backup client (BR) must determine the suitable concurrency number in some ad-hoc way.
This PR solves both issue by moving the thread pool size back as a TiKV config:
The default value is set to (0.75 × Number of CPUs) to better utilize the available resources. The value can still be dynamically configured, but given this more practical default value it should be much less needed.
Related changes
pingcap/docs/pingcap/docs-cn:pingcap/tidb-ansible:Check List
Tests
Side effects
Release note
backup.num-threadsis introduced to control the backup thread pool size.