-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
batch_system: use lru cache (#8343) #8355
Merged
breezewish
merged 2 commits into
tikv:release-3.0
from
ti-srebot:release-3.0-3739657ff807
Jul 28, 2020
Merged
batch_system: use lru cache (#8343) #8355
breezewish
merged 2 commits into
tikv:release-3.0
from
ti-srebot:release-3.0-3739657ff807
Jul 28, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
@BusyJay please accept the invitation then you can push to the cherry-pick pull requests. |
MyonKeminta
approved these changes
Jul 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
breezewish
approved these changes
Jul 28, 2020
/merge |
/run-all-tests |
@ti-srebot merge failed. |
/run-integration-common-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
priority/release-blocker
This PR blocks a release. Please review it ASAP.
status/can-merge
Status: Can merge to base branch
status/LGT2
Status: PR - There are already 2 approvals
type/bugfix
Type: PR - Fix a bug
type/cherry-pick
Type: PR - Cherry pick
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #8343 to release-3.0
What problem does this PR solve?
Issue Number: close #8315
Problem Summary:
When a mailbox is closed, it maybe kept in cache and never be dropped.
This PR uses lru cache to limit the impact and prevent memory from
growing infinitely.
Related changes
pingcap/docs
/pingcap/docs-cn
:pingcap/tidb-ansible
:Check List
Tests
Release note