Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

batch_system: use lru cache (#8343) #8355

Merged
merged 2 commits into from
Jul 28, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #8343 to release-3.0


What problem does this PR solve?

Issue Number: close #8315

Problem Summary:

When a mailbox is closed, it maybe kept in cache and never be dropped.
This PR uses lru cache to limit the impact and prevent memory from
growing infinitely.

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • PR to update pingcap/tidb-ansible:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Release note

  • fix memory leak during scheduling

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added sig/raft Component: Raft, RaftStore, etc. priority/release-blocker This PR blocks a release. Please review it ASAP. sig/raft type/bugfix Type: PR - Fix a bug type/cherry-pick Type: PR - Cherry pick labels Jul 28, 2020
@ti-srebot ti-srebot added this to the v3.0.18 milestone Jul 28, 2020
@ti-srebot
Copy link
Contributor Author

@BusyJay please accept the invitation then you can push to the cherry-pick pull requests.
https://github.com/ti-srebot/tikv/invitations

@BusyJay BusyJay removed sig/raft Component: Raft, RaftStore, etc. sig/raft labels Jul 28, 2020
Copy link
Contributor

@MyonKeminta MyonKeminta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Status: PR - There is already 1 approval label Jul 28, 2020
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
@ti-srebot ti-srebot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Jul 28, 2020
@breezewish
Copy link
Member

/merge

@ti-srebot ti-srebot added the status/can-merge Status: Can merge to base branch label Jul 28, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@breezewish
Copy link
Member

/run-integration-common-test

@breezewish breezewish merged commit ed2f583 into tikv:release-3.0 Jul 28, 2020
@BusyJay BusyJay modified the milestones: v3.0.18, v3.0.17 Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/release-blocker This PR blocks a release. Please review it ASAP. status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals type/bugfix Type: PR - Fix a bug type/cherry-pick Type: PR - Cherry pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants