Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rocksdb: add config for rate_limiter.refill_period #8371

Merged
merged 19 commits into from Aug 5, 2020
Merged

rocksdb: add config for rate_limiter.refill_period #8371

merged 19 commits into from Aug 5, 2020

Conversation

tabokie
Copy link
Member

@tabokie tabokie commented Jul 30, 2020 •
edited

Signed-off-by: tabokie xy.tao@outlook.com

What is changed and how it works?

Expose rocksdb config refill_period_us for rate limiter to tikv.

refill_period_us is used to control the largest IO quota that can be requested from IO rate limiter at a single time. Tuning down this parameter will flatten the IO burst with a penalty on CPU usage. Default value is 100 ms.

Release note

  • Add config for rate limiter's refill-period

BusyJay and others added 8 commits July 24, 2020 17:25
@BusyJay
tikv_alloc: update jemalloc to 5.2.1
0af4f3a 
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
@BusyJay
fix compilation
95b999b 
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
@BusyJay
enable mem-profiling by default
cfefd9f 
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
@BusyJay
disable mem-profiling by default
37f62a0 
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
@BusyJay
Merge branch 'master' into update-jemalloc
84a4894 
Signed-off-by: Jay Lee <BusyJayLee@gmail.com>
@BusyJay
Merge branch 'master' into update-jemalloc
befc073
@BusyJay
Merge branch 'master' into update-jemalloc
4669c89
@tabokie
add config for refill_period
95f4f92 
Signed-off-by: tabokie <xy.tao@outlook.com>
@sre-bot
Copy link
Contributor

sre-bot commented Jul 30, 2020

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@tabokie tabokie added component/rocksdb Component: RocksDB engine status/DNM labels Jul 30, 2020
@tabokie
fix missing quote
5fc9145 
Signed-off-by: tabokie <xy.tao@outlook.com>
@yiwu-arbug yiwu-arbug added the sig/engine SIG: Engine label Jul 30, 2020
@yiwu-arbug yiwu-arbug added this to In Progress(Developing) in Engine SIG via automation Jul 30, 2020
@yiwu-arbug yiwu-arbug added the type/enhancement Type: Issue - Enhancement label Jul 30, 2020
@yiwu-arbug
Copy link
Contributor

Please give more details in the PR summary.

@tabokie
address comments
224d4b8 
Signed-off-by: tabokie <xy.tao@outlook.com>
@tabokie
Merge branch 'update-jemalloc' of https://github.com/BusyJay/tikv int…
f497ac7 
…o opt_refill
@tabokie
update Cargo.lock
2122576 
Signed-off-by: tabokie <xy.tao@outlook.com>
@tabokie
fix compile error
87adf72 
Signed-off-by: tabokie <xy.tao@outlook.com>
@tabokie
Copy link
Member Author

tabokie commented Jul 31, 2020

/release

@sre-bot
Copy link
Contributor

sre-bot commented Jul 31, 2020

download tikv at http://fileserver.pingcap.net/download/builds/pingcap/tikv/pr/87adf72b5e05d34b8d77371108811ef86ecf3630/centos7/tikv-server.tar.gz

@yiwu-arbug yiwu-arbug changed the title add config for rate_limiter.refill_period rocksdb: add config for rate_limiter.refill_period Aug 1, 2020
yiwu-arbug
yiwu-arbug reviewed Aug 1, 2020
View reviewed changes
Copy link
Contributor

@yiwu-arbug yiwu-arbug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert jemalloc related changes? Also the rust-rocksdb PR is merged.

Connor1996
Connor1996 approved these changes Aug 3, 2020
View reviewed changes
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Status: PR - There is already 1 approval label Aug 3, 2020
@Connor1996
Copy link
Member

test fails

@tabokie
fix comment
9513ffa 
Signed-off-by: tabokie <xy.tao@outlook.com>
@tabokie
fix config test
532c5f8 
Signed-off-by: tabokie <xy.tao@outlook.com>
@tabokie
Merge branch 'master' into opt_refill
37285c7
yiwu-arbug
yiwu-arbug approved these changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@yiwu-arbug yiwu-arbug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Aug 5, 2020
@yiwu-arbug
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Status: Can merge to base branch label Aug 5, 2020
@yiwu-arbug yiwu-arbug mentioned this pull request Aug 5, 2020
Merged
@ti-srebot
Copy link
Contributor

/run-all-tests

@yiwu-arbug yiwu-arbug merged commit 3546246 into tikv:master Aug 5, 2020
Engine SIG automation moved this from In Progress(Developing) to Done Aug 5, 2020
@tabokie tabokie deleted the opt_refill branch December 23, 2020 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiwu-arbug yiwu-arbug yiwu-arbug approved these changes

@Connor1996 Connor1996 Connor1996 approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

Assignees
No one assigned
Labels
component/rocksdb Component: RocksDB engine sig/engine SIG: Engine status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals type/enhancement Type: Issue - Enhancement
Projects
Engine SIG
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tabokie @sre-bot @yiwu-arbug @Connor1996 @ti-srebot @BusyJay