Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gc_worker: collect locks after applying (#8217) #8460

Merged
merged 3 commits into from
Sep 8, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #8217 to release-4.0


Signed-off-by: youjiali1995 zlwgx1023@gmail.com

What problem does this PR solve?

Issue Number: close #8211
Problem Summary:
See the issue.

What is changed and how it works?

What's Changed:

Notifying lock observer after applying logs.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Release note

  • Fix the issue that green GC may miss locks during transferring regions.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@youjiali1995
Copy link
Contributor

/run-all-tests

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
@youjiali1995 youjiali1995 added this to the v4.0.6 milestone Sep 7, 2020
@youjiali1995
Copy link
Contributor

@sticnarf @MyonKeminta PTAL.

1 similar comment
@youjiali1995
Copy link
Contributor

@sticnarf @MyonKeminta PTAL.

@youjiali1995 youjiali1995 added the priority/release-blocker This PR blocks a release. Please review it ASAP. label Sep 8, 2020
Copy link
Contributor

@sticnarf sticnarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Status: PR - There is already 1 approval label Sep 8, 2020
@ti-srebot ti-srebot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Sep 8, 2020
@youjiali1995
Copy link
Contributor

/run-all-tests

@Connor1996
Copy link
Member

/merge

@ti-srebot ti-srebot added the status/can-merge Status: Can merge to base branch label Sep 8, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@Connor1996
Copy link
Member

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit 64c5553 into tikv:release-4.0 Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/release-blocker This PR blocks a release. Please review it ASAP. sig/transaction SIG: Transaction status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals type/bugfix Type: PR - Fix a bug type/cherry-pick Type: PR - Cherry pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants