-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gc_worker: collect locks after applying (#8217) #8460
Merged
ti-srebot
merged 3 commits into
tikv:release-4.0
from
ti-srebot:release-4.0-f13f949bf0b2
Sep 8, 2020
Merged
gc_worker: collect locks after applying (#8217) #8460
ti-srebot
merged 3 commits into
tikv:release-4.0
from
ti-srebot:release-4.0-f13f949bf0b2
Sep 8, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/run-all-tests |
e9961b5
to
699980a
Compare
/run-all-tests |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Signed-off-by: youjiali1995 <zlwgx1023@gmail.com>
699980a
to
354974a
Compare
@sticnarf @MyonKeminta PTAL. |
1 similar comment
@sticnarf @MyonKeminta PTAL. |
sticnarf
reviewed
Sep 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
MyonKeminta
approved these changes
Sep 8, 2020
/run-all-tests |
/merge |
/run-all-tests |
@ti-srebot merge failed. |
/merge |
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
priority/release-blocker
This PR blocks a release. Please review it ASAP.
sig/transaction
SIG: Transaction
status/can-merge
Status: Can merge to base branch
status/LGT2
Status: PR - There are already 2 approvals
type/bugfix
Type: PR - Fix a bug
type/cherry-pick
Type: PR - Cherry pick
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #8217 to release-4.0
Signed-off-by: youjiali1995 zlwgx1023@gmail.com
What problem does this PR solve?
Issue Number: close #8211
Problem Summary:
See the issue.
What is changed and how it works?
What's Changed:
Notifying lock observer after applying logs.
Related changes
Check List
Tests
Release note