Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raftstore: destroy process must be asynchronous if peer is initialized (#8455) #8497

Merged
merged 6 commits into from
Sep 8, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #8455 to release-4.0


Signed-off-by: Liqi Geng gengliqiii@gmail.com

What problem does this PR solve?

Issue Number: close #8433

Problem Summary:

Destroy process must be asynchronous if peer is initialized.
The details is in #8433.

What is changed and how it works?

What's Changed:
described above

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Integration test

Side effects

No

Release note

  • Fix a panic issue if a TiKV runs very slow during conf change.

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added sig/raft Component: Raft, RaftStore, etc. type/cherry-pick Type: PR - Cherry pick labels Aug 24, 2020
@ti-srebot ti-srebot added this to the v4.0.6 milestone Aug 24, 2020
@ti-srebot ti-srebot added the status/LGT1 Status: PR - There is already 1 approval label Sep 8, 2020
@ti-srebot
Copy link
Contributor Author

@NingLin-P,Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments.See the corresponding SIG page for more information. Related SIG: raft(slack).

Signed-off-by: gengliqi <gengliqiii@gmail.com>
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor Author

@Connor1996,Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments.See the corresponding SIG page for more information. Related SIG: raft(slack).

@Connor1996
Copy link
Member

/merge

@ti-srebot ti-srebot added the status/can-merge Status: Can merge to base branch label Sep 8, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@Connor1996
Copy link
Member

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 8460

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@Connor1996
Copy link
Member

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 8620
  • 8427
  • 8618
  • 8612

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit 8962bcb into tikv:release-4.0 Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/raft Component: Raft, RaftStore, etc. status/can-merge Status: Can merge to base branch status/LGT1 Status: PR - There is already 1 approval type/cherry-pick Type: PR - Cherry pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants