cdc: fix incorrect resolved ts timeout #8573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
overvenus
reviewed
Sep 2, 2020
components/cdc/src/endpoint.rs
Outdated
| futures03::future::join(tso, timeout.compat().map_err(|_| unreachable!())).await; | ||
| let _ = timeout.compat().await; | ||
| // Ignore get tso errors since we will retry every `min_ts_interval`. | ||
| let mut min_ts = tso.unwrap_or_default(); | ||
| let mut min_ts = tso.await.unwrap_or_default(); |
There was a problem hiding this comment.
If tso response arrives immediately, it still delays a timeout.
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
MyonKeminta
reviewed
Sep 3, 2020
MyonKeminta
approved these changes
Sep 3, 2020
ti-srebot
approved these changes
Sep 3, 2020
|
/merge |
|
/run-all-tests |
5kbpers
added
the
needs-cherry-pick-release-4.0
ti-srebot
pushed a commit
to ti-srebot/tikv
that referenced
this pull request
Sep 3, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #8588 |
Yes, previously resolved ts has at least 1s gap and now it was eliminated. |
5kbpers
added a commit
to ti-srebot/tikv
that referenced
this pull request
Sep 3, 2020
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
ti-srebot
added a commit
that referenced
this pull request
Sep 9, 2020
ldeng-ustc
pushed a commit
to ldeng-ustc/tikv
that referenced
this pull request
Sep 12, 2020
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: 5kbpers tangminghua@pingcap.com
What problem does this PR solve?
Problem Summary:
Resolved ts was advanced periodically by getting tso and waiting for timeout simultaneously, which makes tso delayed.
What is changed and how it works?
Get tso after timeout.
Proposal: xxx
What's Changed:
Related changes
Check List
Tests
Release note