Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error-code: support to generate metafile (#8609) #8619

Merged
merged 4 commits into from
Sep 9, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #8609 to release-4.0


What problem does this PR solve?

Problem Summary:
Support to generate the metafile of error codes, then other programs can parse error codes through it.

What is changed and how it works?

What's Changed:

  • Add executable binary to error code crate
  • Add cmd in Makefile

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    • make error-code

Release note

  • error-code: support to generate metafile

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added the type/cherry-pick Type: PR - Cherry pick label Sep 8, 2020
@ti-srebot ti-srebot added this to the v4.0.6 milestone Sep 8, 2020
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
@ti-srebot ti-srebot added the status/LGT1 Status: PR - There is already 1 approval label Sep 8, 2020
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
@ti-srebot ti-srebot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Sep 9, 2020
@5kbpers
Copy link
Member

5kbpers commented Sep 9, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Status: Can merge to base branch label Sep 9, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit d9ba13b into tikv:release-4.0 Sep 9, 2020
@5kbpers 5kbpers deleted the release-4.0-f2ab51178bd4 branch September 9, 2020 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Status: Can merge to base branch status/LGT2 Status: PR - There are already 2 approvals type/cherry-pick Type: PR - Cherry pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants