Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error_code: re-format metafile (#8870) #8877

Merged
merged 4 commits into from
Oct 23, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #8870 to release-4.0


Signed-off-by: 5kbpers tangminghua@pingcap.com

What is changed and how it works?

Proposal: xxx

What's Changed:

Re-format metafile of error codes.

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Release note

  • error_code: re-format metafile

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added the type/cherry-pick Type: PR - Cherry pick label Oct 22, 2020
@ti-srebot ti-srebot added this to the v4.0.8 milestone Oct 22, 2020
Signed-off-by: 5kbpers <tangminghua@pingcap.com>
@ti-srebot ti-srebot added the status/LGT1 Status: PR - There is already 1 approval label Oct 23, 2020
Copy link
Contributor

@sticnarf sticnarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Status: PR - There are already 2 approvals and removed status/LGT1 Status: PR - There is already 1 approval labels Oct 23, 2020
@sticnarf
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Status: Can merge to base branch label Oct 23, 2020
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot
Copy link
Contributor Author

@ti-srebot merge failed.

@sticnarf
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added status/LGT3 and removed status/LGT2 Status: PR - There are already 2 approvals labels Oct 23, 2020
@5kbpers 5kbpers merged commit 8f0aca5 into tikv:release-4.0 Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Status: Can merge to base branch status/LGT3 type/cherry-pick Type: PR - Cherry pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants