storage: return memory locks as BatchGet response level error #9077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
sticnarf
added
sig/transaction
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
src/server/service/kv.rs
Outdated
| resp.set_pairs(pairs.into()); | ||
| } | ||
| Err(e) => { | ||
| resp.set_error(extract_key_error(&e)); |
There was a problem hiding this comment.
Is it backward compatible? What if an error except KeyIsLocked in replica read is reported?
There was a problem hiding this comment.
Indeed. It looks possible for async_snapshot to return some weird errors like Timeout or some unexpected errors. Then, an old client may not handle the error correctly.
There was a problem hiding this comment.
I keep the error in the first kvpair. PTAL again.
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
|
@MyonKeminta PTAL |
ti-srebot
approved these changes
Nov 24, 2020
|
/merge |
|
/run-all-tests |
|
@sticnarf merge failed. |
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
@sticnarf merge failed. |
|
/run-all-tests |
|
/merge |
|
/run-all-tests |
|
@sticnarf merge failed. |
|
/merge |
|
/run-all-tests |
This was referenced Nov 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #9069
What is changed and how it works?
Set memory lock to the newly added
KeyErrorfield inBatchGetResponse. The client will skip usingpairsif the error is used.Related changes
Check List
Tests
Release note