concurrency manager: fix a memory leak when iterating skiplist #9722
Conversation
sticnarf
force-pushed
the
skiplist-memory-leak
branch
from
05ee6a5
to
e9f05e8
Compare
sticnarf
force-pushed
the
skiplist-memory-leak
branch
from
e9f05e8
to
d54957f
Compare
|
@youjiali1995 There appears to be other more minor leaks and I am looking for the reason. I want to open the PR after finding the others. |
| git = "https://github.com/crossbeam-rs/crossbeam.git" | ||
| tag = "crossbeam-0.7.3" | ||
| git = "https://github.com/sticnarf/crossbeam.git" | ||
| branch = "tikv" |
There was a problem hiding this comment.
I think we should use a ref rather than a branch to ensure we're all building the same version
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
ti-chi-bot
added
status/LGT2
sticnarf
force-pushed
the
skiplist-memory-leak
branch
from
4461991
to
a89e51c
Compare
Signed-off-by: Yilin Chen <sticnarf@gmail.com>
sticnarf
force-pushed
the
skiplist-memory-leak
branch
from
a89e51c
to
4c4bf75
Compare
| [dependencies.crossbeam-skiplist] | ||
| git = "https://github.com/crossbeam-rs/crossbeam.git" | ||
| tag = "crossbeam-0.7.3" | ||
| git = "https://github.com/sticnarf/crossbeam.git" |
There was a problem hiding this comment.
Although the fix is already merged to the upstream, I use my own branch to make it possible to use the crates.io version of crossbeam-utils and crossbeam-epoch.
There was a problem hiding this comment.
just curious, what are the advantages of the crates.io version?
There was a problem hiding this comment.
I just don't want another copy of these dependencies...
|
@nrc @youjiali1995 Please take a second look |
|
/merge |
|
@sticnarf: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger If you have any questions about the PR merge process, please refer to pr process. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. Commit hash: 4c4bf75
|
|
@sticnarf: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
When checking memory locks of a range, memory leaks happen.
What is changed and how it works?
It's due to a bug in crossbeam-skiplist. I fix it in my own branch and this PR will fix it.
Fixed in upstream: crossbeam-rs/crossbeam#673
Related changes
Check List
Tests
Run long-running tests to see if memory leaks still exist manually.
Release note