Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Many chips do not honor 0Cxx retrigger if the sample has finished playing #1684

Closed
mooinglemur opened this issue Jan 3, 2024 · 3 comments
Closed

Many chips do not honor 0Cxx retrigger if the sample has finished playing #1684

mooinglemur opened this issue Jan 3, 2024 · 3 comments
Assignees
@tildearrow
Labels
bug Something isn't working done issue resolved

Comments

@mooinglemur
Copy link
Contributor

mooinglemur commented Jan 3, 2024 •
edited by tildearrow

On VERA PCM, YM2612 DAC, AY PCM, and a lot of other chips, if the sample has not finished playing, the 0Cxx retrigger will restart playback, but if it has finished, it has no effect. This is unlike Amiga, where a retrigger will replay the sample even if it has finished playing, and even if the original note was on a previous row.
@tildearrow tildearrow added the bug Something isn't working label Jan 13, 2024
@tildearrow
Copy link
Owner

tildearrow commented Jan 20, 2024 •
edited

It appears this also happens on Generic PCM DAC.
Also on PC Engine...
Also on YM2612...

@tildearrow tildearrow removed the bug Something isn't working label Jan 20, 2024
@tildearrow tildearrow changed the title VERA PCM does not honor 0Cxx retrigger if the sample has finished playing Many chips do not honor 0Cxx retrigger if the sample has finished playing Jan 27, 2024
@tildearrow tildearrow added the bug Something isn't working label Jan 27, 2024
@lunathir
Copy link
Contributor

lunathir commented Jan 30, 2024 •
edited

I tried with ES5506 and that didn’t retrigger at all, on ESFM Contest build.

@tildearrow tildearrow self-assigned this Jan 31, 2024
tildearrow added a commit that referenced this issue Jan 31, 2024
@tildearrow
prepare for issues #1554 and #1684
532f00a
@tildearrow
Copy link
Owner

Fixed!

@tildearrow tildearrow added the done issue resolved label Feb 2, 2024
@tildearrow tildearrow reopened this Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tildearrow tildearrow

Labels
bug Something isn't working done issue resolved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mooinglemur @tildearrow @lunathir