Read asset paths from EmberApp outputPaths option #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var appName = process.env.EMBER_CLI_FASTBOOT_APP_NAME || this.project.name(); | ||
|
|
||
| return this.runCommand(appName, options); | ||
| var appOutputPaths = JSON.parse(process.env.EMBER_CLI_FASTBOOT_APP_OUTPUT_PATHS); |
There was a problem hiding this comment.
This needs to have a fallback. Otherwise fastboot can only be used while building (since included hook is only ran for builds).
Maybe we should add a fastboot specific config file at config/fastboot.js for the shared config?
There was a problem hiding this comment.
@rwjblue not sure how to proceed here. Since the app has to be built at least once to serve it, write the output paths to a temp file?
xg-wang
pushed a commit
to xg-wang/ember-cli-fastboot
that referenced
this pull request
Nov 16, 2020
…mocha-5.0.0 Update mocha to the latest version 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36