Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-deprecate this-property-fallback #10

Merged
merged 12 commits into from
May 16, 2023
Merged

Re-deprecate this-property-fallback #10

merged 12 commits into from
May 16, 2023

Conversation

gitKrystan
Copy link
Collaborator

@gitKrystan gitKrystan commented May 10, 2023

🙃

Because the intent of this library is to allow users to upgrade to Ember 4.0+ while they still in the process of resolving this-property-fallback deprecations, this library includes the this-property-fallback deprecation from Ember 3.x. You can follow the instructions here for handling these deprecations.

Copy link
Contributor

@wycats wycats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

addon/deprecations-helper.ts Show resolved Hide resolved
addon/deprecations-helper.ts Outdated Show resolved Hide resolved
addon/this-fallback-helper.ts Outdated Show resolved Hide resolved
lib/helpers/deprecations.ts Show resolved Hide resolved
lib/helpers/fallback.ts Outdated Show resolved Hide resolved
lib/helpers/fallback.ts Outdated Show resolved Hide resolved
lib/helpers/fallback.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@wycats wycats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@gitKrystan gitKrystan force-pushed the add-deprecations branch 2 times, most recently from 613365b to 62855f0 Compare May 12, 2023 00:46
@gitKrystan gitKrystan marked this pull request as ready for review May 12, 2023 00:56
@gitKrystan gitKrystan merged commit 431dd66 into main May 16, 2023
10 of 11 checks passed
@gitKrystan gitKrystan deleted the add-deprecations branch May 16, 2023 19:59
@gitKrystan gitKrystan added the enhancement New feature or request label May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants