Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow logging to be disabled #16

Merged
merged 2 commits into from
May 17, 2023
Merged

Allow logging to be disabled #16

merged 2 commits into from
May 17, 2023

Conversation

gitKrystan
Copy link
Collaborator

@gitKrystan gitKrystan commented May 16, 2023

You can now configure this addon under the 'ember-this-fallback' key in the EmberApp constructor options:

"use strict";

const EmberApp = require("ember-cli/lib/broccoli/ember-app");

module.exports = function (defaults) {
  const app = new EmberApp(defaults, {
    //...
    "ember-this-fallback": {
      /**
       * Disable all logging, including debug logging (even with the `DEBUG`
       * environment variable) and logging to `ember-this-fallback-plugin.log`.
       */
      enableLogging: false,
    },
  });
  // ...
};

@gitKrystan gitKrystan force-pushed the logger-config branch 8 times, most recently from 76cb488 to dcdff79 Compare May 16, 2023 19:57
@gitKrystan gitKrystan added the enhancement New feature or request label May 16, 2023
@gitKrystan gitKrystan merged commit 38feacc into main May 17, 2023
11 of 12 checks passed
@gitKrystan gitKrystan deleted the logger-config branch May 17, 2023 18:25
@gitKrystan gitKrystan added breaking Breaking change to be mentioned in the changelog/release notes. bug Something isn't working internal Internal changes that still require a mention in the changelog/release notes. and removed bug Something isn't working internal Internal changes that still require a mention in the changelog/release notes. breaking Breaking change to be mentioned in the changelog/release notes. labels May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants