This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wagenet
force-pushed
the
duration_wip_windows
branch
from
March 1, 2017 18:16
9f755df
to
9ec099d
Compare
wagenet
force-pushed
the
duration_wip_windows
branch
20 times, most recently
from
March 3, 2017 22:49
f962c65
to
d797c63
Compare
wagenet
force-pushed
the
duration_wip_windows
branch
from
March 3, 2017 23:23
f798b04
to
d6c4fe3
Compare
wagenet
force-pushed
the
duration_wip_windows
branch
10 times, most recently
from
March 4, 2017 00:36
a4b2acb
to
2d358a4
Compare
@wycats @chancancode I believe this is ready enough to merge. Once merged, I can make new tickets with the other items or add them to the master ticket. |
wagenet
force-pushed
the
duration_wip_windows
branch
from
March 7, 2017 19:56
67c0d8a
to
94a48b4
Compare
chancancode
reviewed
Mar 7, 2017
crates/libcruby-sys/src/lib.rs
Outdated
pub const RUNTIME_VERSION: &'static str = env!("CARGO_PKG_VERSION"); | ||
|
||
pub fn check_version() { | ||
// All this to look up `HelixRuntime::VERSION`! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of checking the Ruby HelixRuntime::VERSION
, you could just make the C-extension expose an additional real symbol 😛 At the end of the day that is what we are interfacing with, so checking the symbol will probably be more reliable (and easier) than checking a Ruby value.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Status
Pre-Merge To Do
Future To Do
ruby_info.rb
intolibcruby-sys
directory.helix-runtime.lib
withlibcruby-sys
.