Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

Initial Windows Support #29

Merged
merged 20 commits into from
Mar 7, 2017
Merged

Initial Windows Support #29

merged 20 commits into from
Mar 7, 2017

Conversation

wagenet
Copy link
Collaborator

@wagenet wagenet commented Mar 1, 2017

Current Status

  • Ready to merge!

Pre-Merge To Do

  • Get helix_runtime tests passing
  • Automate helix_runtime.def generation
  • Automate helix_runtime.lib generation
  • Automate ruby .lib generation (or find alternative)
  • Don't hardcode Ruby version
  • Figure out appropriate ways to handle DLL paths to avoid duplication (See 1 2)
  • Get tests passing for examples/console

Future To Do

  • Look into DLL versioning? Does this actually matter?
  • Examine whether its possible for us to automatically add to the Windows DLL lookup PATH with Bundler
  • Improve extern handling: https://gcc.gnu.org/wiki/Visibility
  • Figure out 64-bit support (WIP: Support 64-bit Windows #32)
  • Automate building of helix-runtime.dll from libcruby-sys (or at least have a message)
  • Move ruby_info.rb into libcruby-sys directory.
  • Package helix-runtime.lib with libcruby-sys.

@wagenet wagenet changed the base branch from duration_wip to master March 3, 2017 20:20
@wagenet wagenet force-pushed the duration_wip_windows branch 20 times, most recently from f962c65 to d797c63 Compare March 3, 2017 22:49
@wagenet wagenet force-pushed the duration_wip_windows branch 10 times, most recently from a4b2acb to 2d358a4 Compare March 4, 2017 00:36
@wagenet wagenet changed the title WIP Windows Support Initial Windows Support Mar 4, 2017
@wagenet
Copy link
Collaborator Author

wagenet commented Mar 4, 2017

@wycats @chancancode I believe this is ready enough to merge. Once merged, I can make new tickets with the other items or add them to the master ticket.

pub const RUNTIME_VERSION: &'static str = env!("CARGO_PKG_VERSION");

pub fn check_version() {
// All this to look up `HelixRuntime::VERSION`!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of checking the Ruby HelixRuntime::VERSION, you could just make the C-extension expose an additional real symbol 😛 At the end of the day that is what we are interfacing with, so checking the symbol will probably be more reliable (and easier) than checking a Ruby value.

@wagenet wagenet merged commit 3c3f21e into master Mar 7, 2017
@wagenet wagenet deleted the duration_wip_windows branch March 7, 2017 21:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants