This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
Array coercions #46
Closed
Array coercions #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wagenet
force-pushed
the
array-coercions
branch
from
08984ed
to
a56f813
Compare
wagenet
force-pushed
the
array-coercions
branch
6 times, most recently
from
4424e25
to
5275b93
Compare
wagenet
force-pushed
the
array-coercions
branch
from
5275b93
to
bcf8cf3
Compare
|
Is there anything holding this back? |
|
We'd love for you to move! I need to allocate some time to review this and remind myself where it currently stands. |
|
Excellent! I think Hash, Array, and Symbol are the only things keeping me from finishing this |
chancancode
pushed a commit
that referenced
this pull request
Oct 5, 2017
This is essentially a rebase of #46 by @wagenet, updated for the new APIs. While it is not ideal to copy most of the time, it is perfectly safe. Therefore we decide to add this in now to enable use cases that are not otherwise possible while we work on a better non-copy version (something like #100). TODO: port the vec -> Ruby Array code from #46 Paired with @hone
|
Between #126 and #127, I think we have covered everything from this PR! (cc @NullVoxPopuli @turboladen @aergonaut @merqlove) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This probably won't be merged without significant changes. I think we'd like to have special Ruby-like Arrays and Hashes that have the same flexibility Ruby does with contents.
TODO: