Skip to content
This repository has been archived by the owner on Apr 4, 2019. It is now read-only.

Make sure input.size is a attribute. #423

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make sure input.size is a attribute. #423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/dom-helper/lib/prop.js
View file
Open in desktop
Expand Up @@ -57,7 +57,10 @@ var ATTR_OVERRIDES = {
// Chrome 46.0.2464.0: 'autocorrect' in document.createElement('input') === false
// Safari 8.0.7: 'autocorrect' in document.createElement('input') === false
// Mobile Safari (iOS 8.4 simulator): 'autocorrect' in document.createElement('input') === true
autocorrect: true
autocorrect: true,
// Will throw an exception(https://github.com/emberjs/ember.js/issues/12413),
// if you set input.size = 'auto'
size: true
},

// element.form is actually a legitimate readOnly property, that is to be
Expand Down
3 changes: 2 additions & 1 deletion packages/dom-helper/tests/prop-test.js
View file
Open in desktop
Expand Up @@ -3,7 +3,7 @@ import { normalizeProperty } from 'dom-helper/prop';
QUnit.module('dom-helper prop');

test('type.attr, for element props that for one reason or another need to be treated as attrs', function() {
expect(13);
expect(14);

[
{ tagName: 'TEXTAREA', key: 'form' },
Expand All @@ -12,6 +12,7 @@ test('type.attr, for element props that for one reason or another need to be tre
{ tagName: 'INPUT', key: 'list' },
{ tagName: 'INPUT', key: 'form' },
{ tagName: 'INPUT', key: 'autocorrect' },
{ tagName: 'INPUT', key: 'size' },
{ tagName: 'OPTION', key: 'form' },
{ tagName: 'INPUT', key: 'form' },
{ tagName: 'BUTTON', key: 'form' },
Expand Down