Decode route before parsing. #70
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the route recognizer match supports decoding before the match, it makes sense for the parser to also decode URI components before it starts parsing the route. This should solve pretenderjs/pretender#124. While the test I added failed both in chrome & phantomjs, this might also be relevant to pretenderjs/pretender#111.
|
Hi! I was wondering if there is any feedback on this PR. |
| @@ -88,6 +88,8 @@ EpsilonSegment.prototype = { | |||
| function parse(route, names, specificity) { | |||
| // normalize route as not starting with a "/". Recognition will | |||
| // also normalize. | |||
| route = decodeURIComponent(route); | |||
There was a problem hiding this comment.
this would decode special URI characters before parsing, so an encoded slash would get parsed as a path separator, decodeURIComponent should not happen before parsing, decodeURI is for normalizing a URI so that all the optionally encoded characters are decoded.
|
Superseded by #55 which is fixing all of the encoding issues in a more holistic manner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the route recognizer
matchrecognizesupports decoding before the match,it makes sense for the parser to also decode URI components before
it starts parsing the route.
This should solve pretenderjs/pretender#124.
While the test I added failed both in chrome & phantomjs, this might
also be relevant to pretenderjs/pretender#111.