-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support nashorn #330
Comments
stefanpenner
added a commit
that referenced
this issue
Nov 30, 2014
* also fix `RSVP.on(‘error’,` on vertex Please note: the test suite itself does not yet run in Nashorn so only some manual testing “proved” it would work. I have relatively good confidence in this, but at some point soon it would be better to get the test suite running on Nashorn. I do suspect it will likely be a sizable investment.
stefanpenner
added a commit
that referenced
this issue
Nov 30, 2014
* also fix `RSVP.on(‘error’,` on vertex Please note: the test suite itself does not yet run in Nashorn so only some manual testing “proved” it would work. I have relatively good confidence in this, but at some point soon it would be better to get the test suite running on Nashorn. I do suspect it will likely be a sizable investment. Conflicts: lib/rsvp/promise.js
stefanpenner
added a commit
that referenced
this issue
Nov 30, 2014
* also fix `RSVP.on(‘error’,` on vertx Please note: the test suite itself does not yet run in Nashorn so only some manual testing “proved” it would work. I have relatively good confidence in this, but at some point soon it would be better to get the test suite running on Nashorn. I do suspect it will likely be a sizable investment. Conflicts: lib/rsvp/promise.js
stefanpenner
added a commit
that referenced
this issue
Nov 30, 2014
NOTE: as Nashorn has real threads, it does not have the same run-to-completion guarentee as the JavaScript you may be familiar with. As such if you are not extremely careful in how you use these threads you will easily put browser/node JavaScript libraries in a bad state. RSVP included. It would be fun to fork RSVP and ensure it’s thread safety. * also fix `RSVP.on(‘error’,` on vertex Also, the test suite itself does not yet run in Nashorn so only some manual testing “proved” it would work. I have relatively good confidence in this, but at some point soon it would be better to get the test suite running on Nashorn. I do suspect it will likely be a sizable investment.
stefanpenner
added a commit
that referenced
this issue
Nov 30, 2014
NOTE: as Nashorn has real threads, it does not have the same run-to-completion guarentee as the JavaScript you may be familiar with. As such if you are not extremely careful in how you use these threads you will easily put browser/node JavaScript libraries in a bad state. RSVP included. It would be fun to fork RSVP and ensure it’s thread safety in such environments, but as no other environment has these requirements it not likely not happen any time soon. * also fix `RSVP.on(‘error’,` on vertex Also, the test suite itself does not yet run in Nashorn so only some manual testing “proved” it would work. I have relatively good confidence in this, but at some point soon it would be better to get the test suite running on Nashorn. I do suspect it will likely be a sizable investment.
wont fix, this requires some additional runtime guarentees |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
i think it's as easy as:
will investigate after thanks giving stuff.
The text was updated successfully, but these errors were encountered: