Correct the README django code #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerebubuth
reviewed
Nov 28, 2017
| int((y_merc - y0) * MVT_EXTENT / y_span), | ||
|
|
||
| tile_based_coords = [] | ||
| for x_merc, y_merc in line: |
There was a problem hiding this comment.
I'm not sure what the line object would be at this point, and whether it would support iteration over the points directly, or (as in Shapely) would need line.coords.
If we don't know that the code example works, would it be better to remove it?
There was a problem hiding this comment.
I tested that it executed, so I'm confident that the code itself doesn't have issues with the api like that. But to your point about removing it, we can go that way too.
There was a problem hiding this comment.
Oh, okay. Cool! If it works, then even better 👍
zerebubuth
approved these changes
Nov 28, 2017
iandees
approved these changes
Nov 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #101
The django code in the README was originally from an outside contribution. I don't know if it just got truncated when things got moved around, but I took a guess at what working code should have looked like.