Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make benchmark script python3 compatible #90

Merged
merged 1 commit into from Mar 8, 2017
Merged

Make benchmark script python3 compatible #90

merged 1 commit into from Mar 8, 2017

Conversation

jalessio
Copy link
Contributor

@jalessio jalessio commented Mar 7, 2017

Standardizes print statements to make the benchmark script compatible with python3.

@nvkelso
Copy link
Member

nvkelso commented Mar 8, 2017

Thanks for the PR, we'll have a look!

@nvkelso nvkelso requested a review from rmarianski March 8, 2017 00:02
@coveralls
Copy link

coveralls commented Mar 8, 2017 •
edited

Coverage Status

Coverage remained the same at 97.156% when pulling a28eac3 on CalthorpeAnalytics:benchmark-python3-compat into ee6e64c on tilezen:master.

zerebubuth
zerebubuth approved these changes Mar 8, 2017
View reviewed changes
Copy link
Member

@zerebubuth zerebubuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@rmarianski rmarianski merged commit d24fa9d into tilezen:master Mar 8, 2017
@jalessio jalessio deleted the benchmark-python3-compat branch March 8, 2017 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmarianski rmarianski rmarianski approved these changes

@zerebubuth zerebubuth zerebubuth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jalessio @nvkelso @coveralls @rmarianski @zerebubuth