Allow configuring job overrides #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that setting an environment variable at Codebuild can override the environment in the Batch job definition, and hence the configuration file in the Batch jobs which run various stages. For example, if we wanted to override the S3 bucket name used for the meta-batch stage, then we could set: `META_BATCH__TILEQUEUE__STORE__NAME=whatever` This allows for lightweight tweaking of the configuration for a particular run, without the heavyweight approach of forking the whole `tileops` repo to change a few variables.
rmarianski
approved these changes
Nov 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow overrides to be passed into
cron.py(i.e: from CodeBuild) and which are passed through to the Batch job environment, which can override the configuration file built into the Docker container. For example, if we wanted to override the meta-batch S3 store name (i.e: bucket), then we could set theJOB_ENV_OVERRIDESenvironment variable to:This allows us to make some small config changes on a run-by-run basis, and means that we don't have to fork the
tileopsrepo to do it.