Add framework to post-process layers #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 2, 2015
| params = step['params'] | ||
|
|
||
| layer = fn(feature_layers, **params) | ||
| if layer is not None: |
There was a problem hiding this comment.
Now that the intercut function won't return None, should we eliminate this check? Or do you foresee other processing functions that may want to signal failures by returning None, and we should keep this around?
zerebubuth
added a commit
that referenced
this pull request
Sep 9, 2015
Add framework to post-process layers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a post-processing step which comes after the functions for transforming and sorting the individual layers. The post-processing step has access to the whole tile, and so it can modify existing layers or create new layers based on existing layers. This allows us to "intercut" one layer with another, see tilezen/TileStache#37, or create layers based purely on already-queried data (e.g: centroids).
Note: this is part of trying to solve tilezen/vector-datasource#136.