New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oneway property should be true, false #1028

Open
nvkelso opened this Issue Sep 8, 2016 · 4 comments

Comments

Projects
None yet
1 participant
@nvkelso
Member

nvkelso commented Sep 8, 2016

We've normalized all the other yes related properties in v1 to be True or False, but oneway is still yes.

Example tile:

yes should be True:

properties: {
kind: "major_road",
name: "Stockton St.",
sort_key: 377,
kind_detail: "tertiary",
source: "openstreetmap.org",
oneway: "yes",
sidewalk: "both",
id: 417400763
},

If it's no, should we even export that as False?

properties: {
source: "openstreetmap.org",
kind: "minor_road",
service: "alley",
oneway: "no",
sort_key: 356,
kind_detail: "service",
id: 332383249
},

@nvkelso nvkelso added this to the v1.0.0 milestone Sep 8, 2016

@nvkelso

This comment has been minimized.

Show comment
Hide comment
@nvkelso

nvkelso Sep 9, 2016

Member

This is a bug fix for tiles in our SemVer doc – and will be an additive change to house styles (which don't show one-way arrows yet). Moving to v1.1

Member

nvkelso commented Sep 9, 2016

This is a bug fix for tiles in our SemVer doc – and will be an additive change to house styles (which don't show one-way arrows yet). Moving to v1.1

@nvkelso nvkelso modified the milestones: v1.1.0, v1.0.0 Sep 9, 2016

@nvkelso

This comment has been minimized.

Show comment
Hide comment
@nvkelso

nvkelso Oct 5, 2016

Member

Related / duplicate:

  • #792 Don't export oneway: no on roads
  • #453 Normalise oneway property
  • #782 Normalize cycleway (& left, right, both variant) values & oneway
Member

nvkelso commented Oct 5, 2016

Related / duplicate:

  • #792 Don't export oneway: no on roads
  • #453 Normalise oneway property
  • #782 Normalize cycleway (& left, right, both variant) values & oneway
@nvkelso

This comment has been minimized.

Show comment
Hide comment
@nvkelso

nvkelso Apr 4, 2017

Member

We're prepping to show oneway arrows on all Mapzen house styles.

Member

nvkelso commented Apr 4, 2017

We're prepping to show oneway arrows on all Mapzen house styles.

@nvkelso nvkelso added the nextnext label Apr 7, 2017

@nvkelso

This comment has been minimized.

Show comment
Hide comment
@nvkelso

nvkelso Apr 20, 2017

Member

Well, turns out there are valid values besides yes and no:

Neither have very many uses in OpenStreetMap today. But thinking about the lanes on I-395 in the Washington, D.C. area that do this, those exceptions are exceptional.

Propose we close this, but still act on some / all of the issues related in #1028 (comment).

Member

nvkelso commented Apr 20, 2017

Well, turns out there are valid values besides yes and no:

Neither have very many uses in OpenStreetMap today. But thinking about the lanes on I-395 in the Washington, D.C. area that do this, those exceptions are exceptional.

Propose we close this, but still act on some / all of the issues related in #1028 (comment).

@nvkelso nvkelso modified the milestones: v1.2.0, v1.1.0 Apr 21, 2017

@nvkelso nvkelso modified the milestones: v1.5.0, v1.4.0 May 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment