-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tile border seams #119
Comments
When looking at our tiles with the tangram renderer, I only see these seams where the @leblowl: does this sound like what you're seeing? I can think of a few approaches to try and solve this:
I like option 1, because it would reduce the number of queries we run, and it should always prevent these seams. |
I've seen the seams where |
Is it easy for you to get the z,x,y tile coordinates for the adjacent tiles where this is happening? |
@jak2030 Water and earth should probably be filled only in client render, not stroked. What use case are you trying to solve (re the roads + water + land render)? The gaps between earth & water vector polygon areas sounds like a bug. @rmarianski I think the source OSM data just has data for coastline (water), and earth is implied by taking the web merc unit boundary (±180/±!90 web merc bbox) - water. But there should be a more consistent generalization for all data, can we trouble shoot why this snapping / quantification is different between the features? Would switching to VW simplification resolve this problem? |
I dug deeper into the seams, and to me it looks like the data in the tiles is correct. I loaded it up into qgis, and when I used the same color for all tiles, things looked like they matched up. I did have to select that the fill and border be the same color, otherwise there indeed was a seam in between that was empty. This is a screenshot with both fill and border set to red after loading some tiles into qgis. Sorry for the red, just attempting to make any gaps striking :) I manually inspected some of the water tiles that were just water, and it looks like the numbers on the adjacent borders do match up exactly. It's important to note that we don't include additional data beyond the tile boundaries. Sometimes renderers expect the tiles to bleed over into one another slightly. We use the exact bounds for the tiles, and don't buffer them. For example, adjacent columns: And adjacent rows: @nvkelso for the earth layer we currently are issuing queries to the database. We use the data from openstreetmapdata.com [1] for zooms >= 9, and use natural earth data for the lower zooms. It could be that the land polygons dataset is derived exactly like you're mentioning though, I'm not sure. I'd personally like to move to deriving this data ourselves dynamically by subtracting the water from the bounding box. That should resolve the issue with earth not aligning with water. |
So I finally looked into this a little more & got an update regarding mapbox-gl-js: mapbox/mapbox-gl-js#1738 It sounds like his answer follows what you were suspecting with the renderer requiring a little bleed. This solves it for me, closing now. Thank you! |
Hey all,
Unfortunately I can't post issues to mapzen/TileStache, so I'll add this here. I am still having issues with seams on tile borders. I haven't looked into it too much, but I thought I'd let ya'll know. It looks like its just occurring with water.
tilezen/TileStache#34
The text was updated successfully, but these errors were encountered: