Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Low zoom (NE) roads missing segments #204

Closed
nvkelso opened this issue Sep 11, 2015 · 4 comments
Closed

Low zoom (NE) roads missing segments #204

nvkelso opened this issue Sep 11, 2015 · 4 comments
Assignees
@zerebubuth

Comments

@nvkelso
Copy link
Member

nvkelso commented Sep 11, 2015

We've regressed the low zoom roads:

screen shot 2015-09-11 at 15 20 41

Probably related:

We've ignored the issue for now by turning off updates on zooms 0-8.
@nvkelso nvkelso added the ready label Sep 11, 2015
@zerebubuth zerebubuth self-assigned this Sep 16, 2015
zerebubuth added a commit to tilezen/TileStache that referenced this issue Sep 16, 2015
@zerebubuth
Better geometry type comparison.
16d386c 
Previously, the comparison had been on Python type. This seemed to
work most of the time, but there were some odd instances of things
claiming to be of `MultiLineString` type, but where
`isinstance(obj, BaseMultipartGeometry)` was `False`. I have a
feeling it might be something `ctypes` related.

It turns out that Shapely doesn't expose the geometry type ID, so
we still have to do a stringly comparison, but I've tried to make
it as simple as possible and do it only once.

This is the base cause of tilezen/vector-datasource#204: Objects
were returned from the intercut algorithm which were
MultiLineStrings, but which were not being detected as such in the
`isinstance` test. This led to some road segments being dropped
from the tile.
@zerebubuth zerebubuth mentioned this issue Sep 16, 2015
Merged
@zerebubuth
Copy link
Member

After tilezen/TileStache#52:

204-missing-roads-fixed

@zerebubuth
Copy link
Member

@nvkelso looks good?

@nvkelso
Copy link
Member Author

nvkelso commented Sep 16, 2015

Yes, looks good.

I see a few gaps in the road network, but those were there before and look to be a Natural Earth road bug: nvkelso/natural-earth-vector#147

@nvkelso
Copy link
Member Author

nvkelso commented Sep 16, 2015

Fixed in tilezen/TileStache#52.

@nvkelso nvkelso closed this as completed Sep 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zerebubuth zerebubuth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rmarianski @zerebubuth @nvkelso