Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project the network tag from the relation. #170

Merged
merged 3 commits into from
Sep 8, 2015

Conversation

zerebubuth
Copy link
Member

Project the network tag, for some classes of roads, from the relations which contain them. Also, don't return relation geometry. This should mean that the ways get all the relevant network information, and also keep the per-way information like brunnel status.

…s which contain them. Also, don't return relation geometry. This should mean that the ways get all the relevant network information, and also keep the per-way information like brunnel status.
@zerebubuth
Copy link
Member Author

Refs #121.

@nvkelso nvkelso assigned zerebubuth and rmarianski and unassigned zerebubuth Sep 4, 2015
@nvkelso
Copy link
Member

nvkelso commented Sep 4, 2015

Rob, please have a look at this Tuesday.

@nvkelso nvkelso added verify and removed in progress labels Sep 4, 2015
@rmarianski
Copy link
Member

👍

Because we're not going to be returning back any relations, seems like we should also get rid of this network check in the index, and no longer have the function accept the network value. I think that part was only returning relations, and is superseded by this pull request.

https://github.com/mapzen/vector-datasource/blob/project-network-tag-from-relations/data/functions.sql#L115

@nvkelso nvkelso added in review and removed verify labels Sep 8, 2015
…ly used on relations (because they don't have a highway value) before, so is now unnecessary.
@zerebubuth
Copy link
Member Author

@rmarianski thanks for spotting that! I've added dcd44cb & 666726c which hopefully do what you were suggesting.

@rmarianski
Copy link
Member

⚡ 👍

zerebubuth added a commit that referenced this pull request Sep 8, 2015
Project the network tag from the relation.
@zerebubuth zerebubuth merged commit ff9f51a into master Sep 8, 2015
@nvkelso nvkelso deleted the project-network-tag-from-relations branch September 8, 2015 17:55
@nvkelso
Copy link
Member

nvkelso commented Sep 8, 2015

Closes #153 and #121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants