Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add man_made tag to roads layer #1928

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add man_made tag to roads layer #1928

wants to merge 1 commit into from

Conversation

rwrx
Copy link
Contributor

@rwrx rwrx commented Sep 30, 2019

Add man_made tag to roads layer

@nvkelso
Copy link
Member

nvkelso commented Sep 30, 2019

What is your aim here?

This PR is too broad as written, is there a specific property or feature you want to add? Having an example OSM feature to focus the discussion would be useful, please.

@rwrx
Copy link
Contributor Author

rwrx commented Oct 1, 2019

We have added this to filter man_made=dyke in roads. I was thinking about adding is as is added pier and quay: https://github.com/tilezen/vector-datasource/blob/master/yaml/roads.yaml#L838 but it can have multiple highway tag values not only path. So I am not sure how to add it properly.

@rwrx
Copy link
Contributor Author

rwrx commented Oct 1, 2019

@nvkelso nvkelso added this to the v1.9.0 milestone Nov 11, 2019
@rwrx rwrx mentioned this pull request Mar 21, 2022
@nvkelso
Copy link
Member

nvkelso commented Mar 21, 2022

If it's a dyke you're after then put this into the landuse layer instead, and just for the value(s) you're interested in.

(We've moved away from adding in any random values from an OSM key and allowlisting them, too.)

@nvkelso
Copy link
Member

nvkelso commented Mar 21, 2022

Should this be closed out in favor of #1929?

@rwrx
Copy link
Contributor Author

rwrx commented Mar 23, 2022

@nvkelso we have added this because of our style similar to OpenTopoMap which also have this for roads. What should I do or change in order for this to be allowed to merge?

@nvkelso nvkelso modified the milestones: v1.9.0, v2.0.0 Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants