Thumbs-up thumbs-down commands should not toggle

[KruyKaze]

When we run these commands remotely, we cannot actually see if the song has already been thumbed up/down.
So can we have these commands not toggle the state and just keep the song thumbed up if it already is for example?
Thank you!

[jiri-janousek]

Hello. Thanks for taking the time to report this issue.

So can we have these commands not toggle the state and just keep the song thumbed up if it already is for example?

This would be inconsistent with behaviour of the web interface. Thumbs up/down actions are toggle actions in the web UI, so they mus be toggle actions in all Nuvola Player interfaces.

When we run these commands remotely, we cannot actually see if the song has already been thumbed up/down.

Supposing you mean command line usage by "run these commands remotely", you can use commands nuvolaplayer3ctl action-state thumbs-up and nuvolaplayer3ctl action-state thumbs-down to get state of the action. Is this helpful?

[jiri-janousek]

Alternatively, it will be possible to use nuvolaplayer3ctl action thumbs-up true to always toggle thumbs up on. Commit tiliado/diorite@d9d654b will be available with the next rebuild of packages. Is this helpful?

[KruyKaze]

Yes that would be perfect. Will it work for "thumbs-down true " as well ?

On Sun, Sep 6, 2015, 03:47 Jiří Janoušek notifications@github.com wrote:

Alternatively, it will be possible to use nuvolaplayer3ctl action
thumbs-up true to always toggle thumbs up on. Commit tiliado/diorite@
d9d654b tiliado/diorite@d9d654b will be
available with the next rebuild of packages. Is this helpful?

—
Reply to this email directly or view it on GitHub
#157 (comment)
.

[jiri-janousek]

Will it work for "thumbs-down true " as well ?

It will work for all toggle actions including thumbs-down.

[KruyKaze]

Excellent. I will now be able to use voice commands to thumb up/down
without worrying about undoing previous actions.
This is great thanks

On Sun, Sep 6, 2015, 03:53 Jiří Janoušek notifications@github.com wrote:

Will it work for "thumbs-down true " as well ?

It will work for all toggle actions including thumbs-down.

—
Reply to this email directly or view it on GitHub
#157 (comment)
.

[KruyKaze]

I have built diorite-git with your latest modification but nuvolaplayer3ctl
action thumbs-up truestill toggles.

Thanks.

On Sun, Sep 6, 2015 at 3:55 AM Mehdi Krit kruykaze@gmail.com wrote:

Excellent. I will now be able to use voice commands to thumb up/down
without worrying about undoing previous actions.
This is great thanks

On Sun, Sep 6, 2015, 03:53 Jiří Janoušek notifications@github.com wrote:

Will it work for "thumbs-down true " as well ?

It will work for all toggle actions including thumbs-down.

—
Reply to this email directly or view it on GitHub
#157 (comment)
.

[jiri-janousek]

I have built diorite-git with your latest modification but nuvolaplayer3ctl action thumbs-up truestill toggles.

Have you also rebuilt Nuvola Player? Could you provide a debugging output from terminal when you type commands nuvolaplayer3ctl action thumbs-up and nuvolaplayer3ctl action thumbs-up true (two times each) in a new terminal window/tab? See Bug Reporting Guidelines for details.

[KruyKaze]

No I didn't think I needed to rebuild nuvola player. That's probably why. I
guess I'll wait until it's updated in arch aur.
Thanks

On Mon, Sep 7, 2015, 03:11 Jiří Janoušek notifications@github.com wrote:

I have built diorite-git with your latest modification but
nuvolaplayer3ctl action thumbs-up truestill toggles.

Have you also rebuilt Nuvola Player? Could you provide a debugging output
from terminal when you type commands nuvolaplayer3ctl action thumbs-up
and nuvolaplayer3ctl action thumbs-up true (two times each) in a new
terminal window/tab? See Bug Reporting Guidelines
https://github.com/tiliado/nuvolaplayer/wiki/Bug-Reporting-Guidelines
for details.

—
Reply to this email directly or view it on GitHub
#157 (comment)
.

[KruyKaze]

I finally rebuilt nuvola and the commands still toggle. Here's the terminal
output: http://pastebin.com/RfPe6Lxz
Thank you

On Sun, Sep 27, 2015 at 6:45 AM Jiří Janoušek notifications@github.com
wrote:

Closed #157 #157.

—
Reply to this email directly or view it on GitHub
#157 (comment).

[KruyKaze]

and here's the debug output : http://pastebin.com/hsBh2ZAT

On Fri, Oct 2, 2015 at 12:03 AM Mehdi Krit kruykaze@gmail.com wrote:

I finally rebuilt nuvola and the commands still toggle. Here's the
terminal output: http://pastebin.com/RfPe6Lxz
Thank you

On Sun, Sep 27, 2015 at 6:45 AM Jiří Janoušek notifications@github.com
wrote:

Closed #157 #157.

—
Reply to this email directly or view it on GitHub
#157 (comment).

[jiri-janousek]

That's interesting. Could you post output of following commands?

1. Find PATH of dioritegtk-0.1.vapi: locate dioritegtk-0.1.vapi
2. Check activate method signature: grep -n "public override void activate" PATH

[KruyKaze]

grep -n "public override void activate"
/usr/share/vala/vapi/dioritegtk-0.1.vapi gives me nothing

On Fri, Oct 2, 2015 at 4:58 AM Jiří Janoušek notifications@github.com
wrote:

That's interesting. Could you post output of following commands?

1. Find PATH of dioritegtk-0.1.vapi: locate dioritegtk-0.1.vapi
2. Check activate method signature: grep -n "public override void
   activate" PATH

—
Reply to this email directly or view it on GitHub
#157 (comment)
.

[jiri-janousek]

grep -n "public override void activate" /usr/share/vala/vapi/dioritegtk-0.1.vapi gives me nothing

It seems you don't have installed the latest commit of Diorite library then.

[KruyKaze]

I installed nuvola from the aur. Then a couple of weeks ago when I
submitted this ticket I installed diorite from github. Then last night I
installed nuvola from github. Should I uninstall then install from git both
packages?
Thanks

On Fri, Oct 2, 2015, 16:29 Jiří Janoušek notifications@github.com wrote:

grep -n "public override void activate"
/usr/share/vala/vapi/dioritegtk-0.1.vapi gives me nothing

It seems you don't have installed the latest commit of Diorite library
then.

—
Reply to this email directly or view it on GitHub
#157 (comment)
.

[KruyKaze]

I uninstalled both nuvola and diorite and reinstalled from AUR .And that
fixed the problem.
Thank you.

On Fri, Oct 2, 2015 at 4:53 PM Mehdi Krit kruykaze@gmail.com wrote:

I installed nuvola from the aur. Then a couple of weeks ago when I
submitted this ticket I installed diorite from github. Then last night I
installed nuvola from github. Should I uninstall then install from git both
packages?
Thanks

On Fri, Oct 2, 2015, 16:29 Jiří Janoušek notifications@github.com wrote:

grep -n "public override void activate"
/usr/share/vala/vapi/dioritegtk-0.1.vapi gives me nothing

It seems you don't have installed the latest commit of Diorite library
then.

—
Reply to this email directly or view it on GitHub
#157 (comment)
.