Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI of scripts #420

Closed
jiri-janousek opened this issue Apr 9, 2018 · 9 comments
Closed

Add CI of scripts #420

jiri-janousek opened this issue Apr 9, 2018 · 9 comments
Labels
type: quality Improves quality of the app or the user experience.

Comments

@jiri-janousek
Copy link
Member

  • Circle CI images → circleci/python:3.6-node-browsers
  • Standard JS
  • Nuvola SDK → nuvolasdk check-project
@jiri-janousek jiri-janousek added the type: quality Improves quality of the app or the user experience. label Apr 9, 2018
jiri-janousek added a commit to tiliado/nuvola-app-deezer that referenced this issue Jun 6, 2018
@jiri-janousek
Add Circle CI
029705b 
Issue: tiliado/nuvolaplayer#420

Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
jiri-janousek added a commit to tiliado/nuvola-app-deezer that referenced this issue Jun 7, 2018
@jiri-janousek
CI: test ./configure and make all
7e51d44 
Issue: tiliado/nuvolaplayer#420

Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
jiri-janousek added a commit to tiliado/nuvola-app-deezer that referenced this issue Jun 7, 2018
@jiri-janousek
CI: test ./configure and make all
1c56633 
Issue: tiliado/nuvolaplayer#420

Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
jiri-janousek added a commit to tiliado/nuvola-app-deezer that referenced this issue Jun 7, 2018
@jiri-janousek
CI: test ./configure and make all
6692818 
Issue: tiliado/nuvolaplayer#420

Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
jiri-janousek added a commit to tiliado/nuvola-app-deezer that referenced this issue Jun 7, 2018
@jiri-janousek
CI: test ./configure and make all
7c2d744 
Issue: tiliado/nuvolaplayer#420

Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
jiri-janousek added a commit to tiliado/nuvola-app-deezer that referenced this issue Jun 7, 2018
@jiri-janousek
CI: test ./configure and make all
bb8295c 
Issue: tiliado/nuvolaplayer#420

Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
jiri-janousek added a commit to tiliado/nuvola-app-deezer that referenced this issue Jun 7, 2018
@jiri-janousek
CI: test ./configure and make all
31a5c71 
Issue: tiliado/nuvolaplayer#420

Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
jiri-janousek added a commit to tiliado/nuvola-app-deezer that referenced this issue Jun 7, 2018
@jiri-janousek
CI: test ./configure and make all
d50077a 
Issue: tiliado/nuvolaplayer#420

Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
jiri-janousek added a commit to tiliado/nuvola-app-deezer that referenced this issue Jun 7, 2018
@jiri-janousek
CI: Store screenshots
30dcb32 
- Issue: tiliado/nuvolaplayer#420
- Issue: tiliado/nuvolasdk#5

Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
@jiri-janousek jiri-janousek added the stalled Some work has been done but nobody is working on finishing this ticket. label Jun 18, 2018
@jiri-janousek jiri-janousek mentioned this issue Sep 26, 2018
Merged
jiri-janousek added a commit to tiliado/nuvola-app-deezer that referenced this issue Sep 26, 2018
@jiri-janousek
Move Circle CI commands to a shell file
4e916cb 
Issue: tiliado/nuvolaplayer#420

Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
@jiri-janousek jiri-janousek added release notes The work on the ticket is ready, but needs to be released and announced. status: in progress and removed stalled Some work has been done but nobody is working on finishing this ticket. release notes The work on the ticket is ready, but needs to be released and announced. labels Sep 26, 2018
jiri-janousek added a commit to tiliado/nuvola-app-deezer that referenced this issue Sep 26, 2018
@jiri-janousek
Use ~/workdir/keep for artifacts
785b482 
Issue: tiliado/nuvolaplayer#420

Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
jiri-janousek added a commit to tiliado/nuvolasdk that referenced this issue Sep 26, 2018
@jiri-janousek
Add Circle CI script
f9f6de2 
Issue: tiliado/nuvolaplayer#420

Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
jiri-janousek added a commit to tiliado/nuvola-app-deezer that referenced this issue Sep 26, 2018
@jiri-janousek
Use CircleCI script from Nuvola SDK
11d993d 
Issue: tiliado/nuvolaplayer#420

Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
@jiri-janousek
Copy link
Member Author

Hello @a-m-s, @d-r-q & @bors-ltd.

  1. Do you have any experience with Circle CI?
  2. Are you ok with me enabling Circle CI for your scripts? I'll do:
    • Add a file .circleci/config.yml: .circleci/config.yml
    • Add a badge to README.md: CircleCI [![CircleCI](https://circleci.com/gh/tiliado/nuvola-app-deezer/tree/master.svg?style=svg)](https://circleci.com/gh/tiliado/nuvola-app-deezer/tree/master)

@a-m-s
Copy link

a-m-s commented Sep 26, 2018

I've never used it. What features are you testing?

@bors-ltd
Copy link

bors-ltd commented Sep 26, 2018 •
edited
Loading

Not with Circle CI itself, but I'm familiar with CI, we use Jenkins at work.

I checked the script and what it covers, that's basically what I'm already doing (except not on the master branch).

@a-m-s
Copy link

a-m-s commented Sep 26, 2018

Oh, I found the script now. You're just checking it builds. That make sense.

I imagined you were going further into UX testing, or code format checking.

@jiri-janousek
Copy link
Member Author

I imagined you were going further into UX testing, [...]

Not yet.

[..] or code format checking.

The CI script runs nuvolasdk check-project which runs a Standard JS code style check.

@jiri-janousek
Copy link
Member Author

The checks are in nuvolasdk/checkproject.py.

@a-m-s
Copy link

a-m-s commented Sep 26, 2018

OK, cool. No objections here. :-)

jiri-janousek added a commit to tiliado/nuvola-app-google-play-music that referenced this issue Sep 29, 2018
@jiri-janousek
Add Circle CI configuration
204ed94 
Issue: tiliado/nuvolaplayer#420
jiri-janousek added a commit to tiliado/nuvola-app-8tracks that referenced this issue Sep 29, 2018
@jiri-janousek
Add Circle CI configuration
dfa91fd 
Issue: tiliado/nuvolaplayer#420
jiri-janousek added a commit to tiliado/nuvola-app-amazon-cloud-player that referenced this issue Sep 29, 2018
@jiri-janousek
Add Circle CI configuration
8ce8630 
Issue: tiliado/nuvolaplayer#420
jiri-janousek added a commit to tiliado/nuvola-app-google-keep that referenced this issue Sep 29, 2018
@jiri-janousek
Add Circle CI configuration
8762552 
Issue: tiliado/nuvolaplayer#420
jiri-janousek added a commit to tiliado/nuvola-app-jango that referenced this issue Sep 29, 2018
@jiri-janousek
Add Circle CI configuration
e3545fb 
Issue: tiliado/nuvolaplayer#420
jiri-janousek added a commit to tiliado/nuvola-app-jupiter-broadcasting that referenced this issue Sep 29, 2018
@jiri-janousek
Add Circle CI configuration
6813fe0 
Issue: tiliado/nuvolaplayer#420
jiri-janousek added a commit to tiliado/nuvola-app-kexp that referenced this issue Sep 29, 2018
@jiri-janousek
Add Circle CI configuration
b977f4c 
Issue: tiliado/nuvolaplayer#420
jiri-janousek added a commit to tiliado/nuvola-app-mixcloud that referenced this issue Sep 29, 2018
@jiri-janousek
Add Circle CI configuration
080a96b 
Issue: tiliado/nuvolaplayer#420
jiri-janousek added a commit to tiliado/nuvola-app-npr-one that referenced this issue Sep 29, 2018
@jiri-janousek
Add Circle CI configuration
11155a6 
Issue: tiliado/nuvolaplayer#420
jiri-janousek added a commit to tiliado/nuvola-app-owncloud-music that referenced this issue Sep 29, 2018
@jiri-janousek
Add Circle CI configuration
6e46b91 
Issue: tiliado/nuvolaplayer#420
jiri-janousek added a commit to tiliado/nuvola-app-pandora that referenced this issue Sep 29, 2018
@jiri-janousek
Add Circle CI configuration
73826ad 
Issue: tiliado/nuvolaplayer#420
jiri-janousek added a commit to tiliado/nuvola-app-plex that referenced this issue Sep 29, 2018
@jiri-janousek
Add Circle CI configuration
6e79fba 
Issue: tiliado/nuvolaplayer#420
jiri-janousek added a commit to tiliado/nuvola-app-pocket-casts that referenced this issue Sep 29, 2018
@jiri-janousek
Add Circle CI configuration
5659cec 
Issue: tiliado/nuvolaplayer#420
jiri-janousek added a commit to tiliado/nuvola-app-qobuz that referenced this issue Sep 29, 2018
@jiri-janousek
Add Circle CI configuration
405b099 
Issue: tiliado/nuvolaplayer#420
jiri-janousek added a commit to tiliado/nuvola-app-siriusxm that referenced this issue Sep 29, 2018
@jiri-janousek
Add Circle CI configuration
f283609 
Issue: tiliado/nuvolaplayer#420
jiri-janousek added a commit to tiliado/nuvola-app-soundcloud that referenced this issue Sep 29, 2018
@jiri-janousek
Add Circle CI configuration
ebb5e02 
Issue: tiliado/nuvolaplayer#420
jiri-janousek added a commit to tiliado/nuvola-app-spotify that referenced this issue Sep 29, 2018
@jiri-janousek
Add Circle CI configuration
2e5d844 
Issue: tiliado/nuvolaplayer#420
jiri-janousek added a commit to tiliado/nuvola-app-tunein that referenced this issue Sep 29, 2018
@jiri-janousek
Add Circle CI configuration
7bcfdb4 
Issue: tiliado/nuvolaplayer#420
jiri-janousek added a commit to tiliado/nuvola-app-yandex-music that referenced this issue Sep 29, 2018
@jiri-janousek
Add Circle CI configuration
b8ea705 
Issue: tiliado/nuvolaplayer#420
jiri-janousek added a commit to tiliado/nuvola-app-youtube that referenced this issue Sep 29, 2018
@jiri-janousek
Add Circle CI configuration
080917a 
Issue: tiliado/nuvolaplayer#420
jiri-janousek added a commit to tiliado/nuvola-app-youtube-music that referenced this issue Sep 29, 2018
@jiri-janousek
Add Circle CI configuration
d9c074f 
Issue: tiliado/nuvolaplayer#420
bors-ltd pushed a commit to tiliado/nuvola-app-qobuz that referenced this issue Sep 30, 2018
@jiri-janousek @bors-ltd
Add Circle CI configuration
0fcae05 
Issue: tiliado/nuvolaplayer#420
a-m-s pushed a commit to tiliado/nuvola-app-bbc-iplayer that referenced this issue Oct 1, 2018
@jiri-janousek @a-m-s
Add Circle CI configuration
5fb2022 
Issue: tiliado/nuvolaplayer#420
a-m-s pushed a commit to tiliado/nuvola-app-amazon-cloud-player that referenced this issue Oct 1, 2018
@jiri-janousek @a-m-s
Add Circle CI configuration
2ca293c 
Issue: tiliado/nuvolaplayer#420
a-m-s pushed a commit to tiliado/nuvola-app-jupiter-broadcasting that referenced this issue Oct 9, 2018
@jiri-janousek @a-m-s
Add Circle CI configuration
4394d95 
Issue: tiliado/nuvolaplayer#420
d-r-q pushed a commit to tiliado/nuvola-app-yandex-music that referenced this issue Oct 11, 2018
@jiri-janousek
Add Circle CI configuration
fbee29c 
Issue: tiliado/nuvolaplayer#420
@jiri-janousek jiri-janousek added release notes The work on the ticket is ready, but needs to be released and announced. and removed status: in progress labels Oct 14, 2018
@jiri-janousek
Copy link
Member Author

Hello @tiliado/nuvola-maintainers, could you join CircleCI Tiliado team to receive notifications when a CI build fails? Thanks :-)

jiri-janousek added a commit to tiliado/nuvolasdk that referenced this issue Oct 14, 2018
@jiri-janousek
new-project, convert-project: add CircleCI
fdcdc37 
Issue: tiliado/nuvolaplayer#420

Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
@jiri-janousek
Copy link
Member Author

Released in Nuvola 4.13.0.

@ghost ghost removed the release notes The work on the ticket is ready, but needs to be released and announced. label Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: quality Improves quality of the app or the user experience.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jiri-janousek @bors-ltd @a-m-s