-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transparent line across the top of the web view #436
Comments
Yeah, it looks as if the top 1 px line was erased. Playing with the offset of the web view X window does not help. |
It's pixel-perfect in ValaCEF so the issue is in Nuvola Runtime. |
A workaround for an erased 1px top line. Issue: #436 Signed-off-by: Jiří Janoušek <janousek.jiri@gmail.com>
Hello @ams, could you confirm that with the latest ADK or any app flatpak (stable or master)?
I'm afraid it is necessary to switch to windowless/off-screen rendering as the current windowed rendering doesn't work well with GTK+ 3 drawing model and it will get even worse with GTK+ 4. CEF supports OSR, but it is not accelerated yet (tiliado/valacef#11). |
Sure, the line is expected in the windowed mode - as I said I added only a workaround with a 1px top margin. But I didn't expect it in the fullscreen mode. Now I remember how the fullscreen is implemented and it makes sense - I thought only the CEF window goes to fullscreen, but the fullscreen applies to the whole Nuvola window including the 1px top margin. |
@a-m-s, could you test with Nuvola/master and |
The first time I ran it I got a Segmentation Fault.
However, subsequent runs all worked correctly, and the annoying line across the top is gone. :-) |
Great, so the offscreen rendering seems to be a promising way to go as it solves three bugs. Unfortunately, the memory & CPU usage suffers as Nuvola needs to keep the pixel buffer around (~40 MB for Full HD) and does the final drawing with CPU instead of GPU (Poster circle gives 23 fps instead of 60 fps). That needs to be optimized. More at tiliado/valacef#11 |
This should be resolved with #583. |
This will be fixed in the QtWebWengine port of Nuvola in #583. The work-in-progress components Wayland Embedded View Framework Server and Wayland Embedded View Framework Client don't exhibit this issue. |
I'm closing this ticket as Nuvola Player has discontinued active development. We are going to provide only integration bug fixes on a best-effort basis until the final End-of-Life on December 31, 2022. I'm sorry that I haven't managed to resolve this ticket in time. |
Blocked by tiliado/valacef#11
There is a transparent line across the top of every web view that does not appear in other browsers. It's typically rendered in white, and is particularly noticeable when watching full-screen videos (e.g. YouTube or BBC).
It's been bugging me for a while, but I've just noticed that it shows up in snapshots taken with the new sidebar too:
You'll probably have to download that image and view it in an external tool to see the problem (Gnome Image Viewer works).
The text was updated successfully, but these errors were encountered: