You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Converted line endings to LF
- Optimized otp_byte_secret for ='s
- main.c test for padding now uses sha1
- main.cpp test now does everything main.c does
- bump license year
test/main.c - I have no idea if sha256 actually works in the first place, its implementation has been guessed on, not verified. I have swapped your edit over to sha1, as these test files serve more as a demonstration and an easy catch when something breaks while developing. Further, I had to change the totp_at to point to the correct code for the generation as produced by another implementation.
test/main.cpp - This file got little love, so I added the same test. It's important to me that these two tests provide the same exact results.
cotp.c otp_byte_secret - Its better to break when c == '=' rather than burning through the rest of the string. For example a string with a 256 buffer who has 8 characters will be padded with 256-8 characters, needlessly burning through the rest of the string. (there should be no embedded =) We need to be responsible for correctly handling the length of the base32_secret because we do not burden the user with providing the length of the base32_secret.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
support base32 padding