Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows quoting #8

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

FreddieAkeroyd
Copy link

  • Fix Makefile quoting for WIn32 build
  • Add epicsShareFunc for lcaMexGblInit

@FreddieAkeroyd
Copy link
Author

Created as draft PR as the most recent tech-talk post mentioned a failure to build ezcaVarArrayTest.exe that I will look into, but everything else built fine

@till-s
Copy link
Owner

till-s commented Jan 7, 2024

Thanks Freddie - so do you recommend holding off merging the PR until you get a chance to look into the ezcaVarArrayTest issue?

@FreddieAkeroyd
Copy link
Author

@till-s I've posted a reply on tech-talk so we can just see if it is something simple , as far as i can see it should work as is, i've not got a matlab installation locally but that part of the build does not require matlab and seems to work fine for me

@till-s
Copy link
Owner

till-s commented Jan 8, 2024

OK - the PR is still marked as 'draft' (preventing it from being merged). Just let me know when it is ready for me to hit the button :-)

@AlessandroDUffizi
Copy link

"@FreddieAkeroyd
Add epicsShareFunc to lcaMexGblInit

My experience on windows compilation is that this modification is fundamental. Otherwise the lcaMexGbIInit won't be exported and the windows compilation fails.
Differently from Linux, Windows doesn't export library functions as default.
So I think is a good idea to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants