Merge pull request #9 from possibly/master

patch: getNeighbours now correctly converts variable to numbers
tillarnold · Oct 6, 2015 · b36e5f3 · b36e5f3
2 parents 639a5d9 + 5b22f3d
commit b36e5f3
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/lib/fixed-2d-array.js b/lib/fixed-2d-array.js
@@ -265,8 +265,8 @@ Fixed2DArray.prototype.getNeighbours = function getNeighbours(row, col, distance
 
   var returnArray = [];
 
-  for (var i = row - distance; i <= row + distance; i++) {
-    for (var j = col - distance; j <= col + distance; j++) {
+  for (var i = row - distance; i <= row + Number(distance); i++) {
+    for (var j = col - distance; j <= col + Number(distance); j++) {
       try {
         if (!(i === row && j === col)) {
           var element = this.get(i, j);

diff --git a/test/test.js b/test/test.js
@@ -96,13 +96,15 @@ test('sameSize',function (t) {
 });
 
 test('get correct number of neighbours',function (t) {
-  t.plan(7);
+  t.plan(8);
   var fa = new fixedArray(9,10);
+  var treatMeLikeANumber = 2;
   t.equal(fa.getNeighbours(5,5).length,8);
   t.equal(fa.getNeighbours(0,0).length,3);
   t.equal(fa.getNeighbours(1,0).length,5);
   t.equal(fa.getNeighbours(0,0,2).length,8);
   t.equal(fa.getNeighbours(2,2,2).length,24);
+  t.equal(fa.getNeighbours(treatMeLikeANumber,treatMeLikeANumber,treatMeLikeANumber).length,24);
   t.equal(fa.getNeighbours(2,2,0).length,0);
   t.equal(fa.getNeighbours(2,2,-2).length,0);
 });