Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current NPM release does not reflect current code #10

Closed
LOZORD opened this issue Jul 7, 2016 · 4 comments
Closed

Current NPM release does not reflect current code #10

LOZORD opened this issue Jul 7, 2016 · 4 comments

Comments

@LOZORD
Copy link

LOZORD commented Jul 7, 2016

If this project isn't dead, there is a nasty bug with the constructor where the two dimension args are flipped (from node_modules/fixed-2d-array/lib/fixed-2d-array.js):

var Fixed2DArray = function Fixed2DArray(width, height, defaultValue) {
  this._width = width;
  this._height = height;
  this._grid = [];
  for (var i = 0; i < width; i++) {
    this._grid[i] = [];
    for (var j = 0; j < height; j++) {
      this._grid[i][j] = defaultValue;
    }
  }
};
@possibly
Copy link
Collaborator

possibly commented Jul 7, 2016

This is just like issue #7 ! I think if we just update the npm package via the instructions here, we should be good to go.

What do you think, @tillarnold ?

@tillarnold
Copy link
Owner

Oh yeah sure we should publish a new version. We might want to publish it as version 2.0 because this is a breaking change, right? I'm currently on my way to work but I can publish the release when I come home.

@tillarnold
Copy link
Owner

I published the release.

@possibly
Copy link
Collaborator

possibly commented Jul 9, 2016

We might want to publish it as version 2.0 because this is a breaking change, right?

Thats what I would have done. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants