Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Huh, height and width are mixed up. #7

Closed
possibly opened this issue Sep 26, 2015 · 1 comment
Closed

Huh, height and width are mixed up. #7

possibly opened this issue Sep 26, 2015 · 1 comment

Comments

@possibly
Copy link
Collaborator

I was showing how Fixed2DArray worked to a friend, and while demoing a Fixed2DArray of size (2,3) a friend point out something so obvious I hadn't seen it before:

var fa = new FixedArray(2,3,0);
console.log(fa._grid);
/*
[
[0, 0, 0],
[0, 0, 0],
]
*/

"Uhm, thats a grid with width three and height 2."

I think she's right, and it's a really simple fix: swap this._height and this._width. A few other things will need adjustment, but I think this change makes more sense in the long run.

Thoughts?

@possibly
Copy link
Collaborator Author

See #8 for pr that fixes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant