Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace rem by px for Safari and Firefox support #544

Merged
merged 1 commit into from
Jun 8, 2019
Merged

fix: replace rem by px for Safari and Firefox support #544

merged 1 commit into from
Jun 8, 2019

Conversation

sun-tea
Copy link
Contributor

@sun-tea sun-tea commented Jun 7, 2019

  • Feature
  • Fix
  • Enhancement

Description

Replace rem by px for svg width and height to avoid warning on Firefox and Safari which do not support rem.

Todo - Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.

@sun-tea sun-tea requested a review from spartDev June 7, 2019 08:29
@spartDev spartDev assigned sun-tea and unassigned spartDev Jun 8, 2019
@spartDev spartDev added bug Something isn't working and removed need review labels Jun 8, 2019
@spartDev spartDev merged commit 365dd2d into master Jun 8, 2019
@spartDev spartDev deleted the replace-rem-to-px branch June 8, 2019 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spartDev spartDev spartDev approved these changes

Assignees

@sun-tea sun-tea

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sun-tea @spartDev